Re: [PATCH 02/10] drm/i915/display: Introduce HAS_CASF macro

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 3/4/2025 3:58 PM, Nemesa Garg wrote:
> Add the macro for casf HAS_CASF.

A bit explanation about the macro and why is this introduced will be good.


>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display_device.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 717286981687..238488c4c3aa 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -191,6 +191,7 @@ struct intel_display_platforms {
>   #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
>   #define HAS_AS_SDP(__display)		(DISPLAY_VER(__display) >= 13)
>   #define HAS_CMRR(__display)		(DISPLAY_VER(__display) >= 20)
> +#define HAS_CASF(__display)		(DISPLAY_VER(__display) >= 20)


I think all other macros are in alphabetical order so would be good to 
follow suite.
CMRR and AS_SDP are the exception, for which I am partly to be blamed as 
a reviwer.

But lets do the right thing for CASF.

Regards,

Ankit

>   #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>   #define I915_HAS_HOTPLUG(__display)	(DISPLAY_INFO(__display)->has_hotplug)
>   #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)