From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [Intel-gfx] [PATCH v2 38/38] drm/i915: move and group properties under display.properties
Date: Wed, 24 Aug 2022 16:16:04 +0300 [thread overview]
Message-ID: <cf7699f412b48bc5ea03e4ddbf862147919ce79d.1661346845.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1661346845.git.jani.nikula@intel.com>
Move display property related members under drm_i915_private display
sub-struct.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic.c | 8 ++++----
drivers/gpu/drm/i915/display/intel_connector.c | 8 ++++----
drivers/gpu/drm/i915/display/intel_display_core.h | 6 ++++++
drivers/gpu/drm/i915/i915_drv.h | 3 ---
4 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
index b94973b5633f..18f0a5ae3bac 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -62,9 +62,9 @@ int intel_digital_connector_atomic_get_property(struct drm_connector *connector,
struct intel_digital_connector_state *intel_conn_state =
to_intel_digital_connector_state(state);
- if (property == dev_priv->force_audio_property)
+ if (property == dev_priv->display.properties.force_audio)
*val = intel_conn_state->force_audio;
- else if (property == dev_priv->broadcast_rgb_property)
+ else if (property == dev_priv->display.properties.broadcast_rgb)
*val = intel_conn_state->broadcast_rgb;
else {
drm_dbg_atomic(&dev_priv->drm,
@@ -95,12 +95,12 @@ int intel_digital_connector_atomic_set_property(struct drm_connector *connector,
struct intel_digital_connector_state *intel_conn_state =
to_intel_digital_connector_state(state);
- if (property == dev_priv->force_audio_property) {
+ if (property == dev_priv->display.properties.force_audio) {
intel_conn_state->force_audio = val;
return 0;
}
- if (property == dev_priv->broadcast_rgb_property) {
+ if (property == dev_priv->display.properties.broadcast_rgb) {
intel_conn_state->broadcast_rgb = val;
return 0;
}
diff --git a/drivers/gpu/drm/i915/display/intel_connector.c b/drivers/gpu/drm/i915/display/intel_connector.c
index 1dcc268927a2..6d5cbeb8df4d 100644
--- a/drivers/gpu/drm/i915/display/intel_connector.c
+++ b/drivers/gpu/drm/i915/display/intel_connector.c
@@ -229,7 +229,7 @@ intel_attach_force_audio_property(struct drm_connector *connector)
struct drm_i915_private *dev_priv = to_i915(dev);
struct drm_property *prop;
- prop = dev_priv->force_audio_property;
+ prop = dev_priv->display.properties.force_audio;
if (prop == NULL) {
prop = drm_property_create_enum(dev, 0,
"audio",
@@ -238,7 +238,7 @@ intel_attach_force_audio_property(struct drm_connector *connector)
if (prop == NULL)
return;
- dev_priv->force_audio_property = prop;
+ dev_priv->display.properties.force_audio = prop;
}
drm_object_attach_property(&connector->base, prop, 0);
}
@@ -256,7 +256,7 @@ intel_attach_broadcast_rgb_property(struct drm_connector *connector)
struct drm_i915_private *dev_priv = to_i915(dev);
struct drm_property *prop;
- prop = dev_priv->broadcast_rgb_property;
+ prop = dev_priv->display.properties.broadcast_rgb;
if (prop == NULL) {
prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
"Broadcast RGB",
@@ -265,7 +265,7 @@ intel_attach_broadcast_rgb_property(struct drm_connector *connector)
if (prop == NULL)
return;
- dev_priv->broadcast_rgb_property = prop;
+ dev_priv->display.properties.broadcast_rgb = prop;
}
drm_object_attach_property(&connector->base, prop, 0);
diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
index bf78b0fcbd11..9086a612365e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_core.h
+++ b/drivers/gpu/drm/i915/display/intel_display_core.h
@@ -27,6 +27,7 @@
#include "intel_pm_types.h"
struct drm_i915_private;
+struct drm_property;
struct i915_audio_component;
struct i915_hdcp_comp_master;
struct intel_atomic_state;
@@ -371,6 +372,11 @@ struct intel_display {
struct mutex mutex;
} pps;
+ struct {
+ struct drm_property *broadcast_rgb;
+ struct drm_property *force_audio;
+ } properties;
+
struct {
unsigned long mask;
} quirks;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 0fee591c35b1..a845b4dfdbee 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -321,9 +321,6 @@ struct drm_i915_private {
struct i915_gpu_error gpu_error;
- struct drm_property *broadcast_rgb_property;
- struct drm_property *force_audio_property;
-
/*
* Shadows for CHV DPLL_MD regs to keep the state
* checker somewhat working in the presence hardware
--
2.34.1
next prev parent reply other threads:[~2022-08-24 13:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 13:15 [Intel-gfx] [PATCH v2 00/38] drm/i915: add display sub-struct to drm_i915_private Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 01/38] " Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 02/38] drm/i915: move cdclk_funcs to display.funcs Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 03/38] drm/i915: move dpll_funcs " Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 04/38] drm/i915: move hotplug_funcs " Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 05/38] drm/i915: move wm_disp funcs " Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 06/38] drm/i915: move fdi_funcs " Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 07/38] drm/i915: move color_funcs " Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 08/38] drm/i915: move and group gmbus members under display.gmbus Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 09/38] drm/i915: move and group pps members under display.pps Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 10/38] drm/i915: move dmc to display.dmc Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 11/38] drm/i915: move and split audio under display.audio and display.funcs Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 12/38] drm/i915: move dpll under display.dpll Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 13/38] drm/i915: move and group fbdev under display.fbdev Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 14/38] drm/i915: move wm to display.wm Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 15/38] drm/i915: move and group hdcp under display.hdcp Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 16/38] drm/i915: move hotplug to display.hotplug Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 17/38] drm/i915: move overlay to display.overlay Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 18/38] drm/i915: move and group sagv under display.sagv Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 19/38] drm/i915: move and group max_bw and bw_obj under display.bw Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 20/38] drm/i915: move opregion to display.opregion Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 21/38] drm/i915: move and group cdclk under display.cdclk Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 22/38] drm/i915: move backlight to display.backlight Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 23/38] drm/i915: move mipi_mmio_base to display.dsi Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 24/38] drm/i915: move vbt to display.vbt Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 25/38] drm/i915: move fbc to display.fbc Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 26/38] drm/i915/vrr: drop window2_delay member from i915 Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 27/38] drm/i915: move and group power related members under display.power Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 28/38] drm/i915: move and group fdi members under display.fdi Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 29/38] drm/i915: move fb_tracking under display sub-struct Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 30/38] drm/i915: move INTEL_FRONTBUFFER_* macros to intel_frontbuffer.h Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 31/38] drm/i915: move dbuf under display sub-struct Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 32/38] drm/i915: move and group modeset_wq and flip_wq under display.wq Jani Nikula
2022-08-24 13:15 ` [Intel-gfx] [PATCH v2 33/38] drm/i915: split gem quirks from display quirks Jani Nikula
2022-08-24 13:16 ` [Intel-gfx] [PATCH v2 34/38] drm/i915/quirks: abstract checking for " Jani Nikula
2022-08-24 13:16 ` [Intel-gfx] [PATCH v2 35/38] drm/i915/quirks: abstract quirks further by making quirk ids an enum Jani Nikula
2022-08-24 13:16 ` [Intel-gfx] [PATCH v2 36/38] drm/i915: move quirks under display sub-struct Jani Nikula
2022-08-24 13:16 ` [Intel-gfx] [PATCH v2 37/38] drm/i915: move atomic_helper " Jani Nikula
2022-08-24 13:16 ` Jani Nikula [this message]
2022-08-24 23:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display sub-struct to drm_i915_private (rev2) Patchwork
2022-08-24 23:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-24 23:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-26 19:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf7699f412b48bc5ea03e4ddbf862147919ce79d.1661346845.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox