[RFC PATCH 00/11] drm/i915: from module params to device params

[Jani Nikula <jani.nikula@intel.com>]

Season's greetings!

This series migrates module parameters to per-device parameters in
drm_i915_private, accessible via debugfs.

Patches 1-6 are fairly straightforward prep work to make the rest
easier. After initial reviews I'll probably submit them separately.

Patches 7-8 add debugfs access to the current module parameters. They
work simultaneously with the module parameter sysfs access.

It is expected that at this point we'll have a transition period, as IGT
needs to be switched over to using the debugfs, but we don't want to
have a flag day.

Patch 9 removes module parameter sysfs write access, leaving debugfs the
only interface to changing module parameters runtime. This breaks IGT.

Patch 10 copies module parameters to dev_priv, and starts using them as
device specific parameters from there, leaving module parameters merely
initial/default values for the device parameters.

Patch 11 makes i915_modparams static to avoid accidental module param
use where device parameters should be used.

The series is thoroughly untested, and CI will greet it with nice red
christmas colors, bringing comfort and joy to us all.

Cheers,
Jani.


Jani Nikula (11):
  drm/i915: add a helper to make a copy of i915_params
  drm/i915: add a helper to free the members of i915_params
  drm/i915/uc: add dev_priv parameter to intel_uc_is_using_* functions
  drm/i915/params: set i915.enable_hangcheck permissions to 0600
  drm/i915: move load failure injection to selftests
  drm/i915/params: document I915_PARAMS_FOR_EACH()
  drm/i915/params: add i915 parameters to debugfs
  drm/i915/params: support bool values for int and uint params
  drm/i915/params: prevent changing module params runtime
  drm/i915/params: switch to device specific parameters
  drm/i915/params: hide i915_modparams within i915_params.c

 drivers/gpu/drm/i915/i915_debugfs.c              | 217 ++++++++++++++++++++++-
 drivers/gpu/drm/i915/i915_drv.c                  |  37 +---
 drivers/gpu/drm/i915/i915_drv.h                  |  28 +--
 drivers/gpu/drm/i915/i915_gem_execbuffer.c       |   2 +-
 drivers/gpu/drm/i915/i915_gpu_error.c            |  22 +--
 drivers/gpu/drm/i915/i915_params.c               |  97 +++++++---
 drivers/gpu/drm/i915/i915_params.h               |  84 +++++----
 drivers/gpu/drm/i915/i915_pci.c                  |   6 +-
 drivers/gpu/drm/i915/i915_selftest.h             |  10 ++
 drivers/gpu/drm/i915/intel_bios.c                |   6 +-
 drivers/gpu/drm/i915/intel_crt.c                 |   4 +-
 drivers/gpu/drm/i915/intel_csr.c                 |   6 +-
 drivers/gpu/drm/i915/intel_device_info.c         |   2 +-
 drivers/gpu/drm/i915/intel_display.c             |  10 +-
 drivers/gpu/drm/i915/intel_dp.c                  |  11 +-
 drivers/gpu/drm/i915/intel_dp_aux_backlight.c    |   3 +-
 drivers/gpu/drm/i915/intel_fbc.c                 |  12 +-
 drivers/gpu/drm/i915/intel_guc_fw.c              |   4 +-
 drivers/gpu/drm/i915/intel_guc_log.c             |   3 +-
 drivers/gpu/drm/i915/intel_gvt.c                 |   8 +-
 drivers/gpu/drm/i915/intel_hangcheck.c           |   2 +-
 drivers/gpu/drm/i915/intel_huc_fw.c              |   4 +-
 drivers/gpu/drm/i915/intel_lvds.c                |   4 +-
 drivers/gpu/drm/i915/intel_opregion.c            |   2 +-
 drivers/gpu/drm/i915/intel_panel.c               |   4 +-
 drivers/gpu/drm/i915/intel_psr.c                 |  14 +-
 drivers/gpu/drm/i915/intel_runtime_pm.c          |  14 +-
 drivers/gpu/drm/i915/intel_uc.c                  |  66 ++++---
 drivers/gpu/drm/i915/intel_uc.h                  |  21 +--
 drivers/gpu/drm/i915/intel_uncore.c              |  18 +-
 drivers/gpu/drm/i915/intel_wopcm.c               |   2 +-
 drivers/gpu/drm/i915/selftests/i915_selftest.c   |  26 +++
 drivers/gpu/drm/i915/selftests/intel_hangcheck.c |   4 +-
 33 files changed, 515 insertions(+), 238 deletions(-)

-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx