From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH 0/8] drm/i915: break intel_display_types.h dependency on i915_drv.h
Date: Mon, 22 Nov 2021 15:51:01 +0200 [thread overview]
Message-ID: <cover.1637588831.git.jani.nikula@intel.com> (raw)
Basically the rule of thumb should be that no headers include
i915_drv.h. It's just too big and includes the world. One of the worst
is intel_display_types.h. Untangle the mess a bit. There are some
changes here that are less than perfect, and there's further cleanup to
be done, but with the dependency gone, it should gradually get easier.
BR,
Jani.
Jani Nikula (8):
drm/i915/display: use drm_crtc_wait_one_vblank() directly when
possible
drm/i915/display: remove intel_wait_for_vblank()
drm/i915/crtc: un-inline some crtc functions and move to
intel_crtc.[ch]
drm/i915/fb: move intel_fb_uses_dpt to intel_fb.c and un-inline
drm/i915: split out intel_pm_types.h
drm/i915: move enum hpd_pin to intel_display.h
drm/i915/display: convert dp_to_i915() to a macro
drm/i915/display: stop including i915_drv.h from intel_display_types.h
drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
drivers/gpu/drm/i915/display/intel_crt.c | 6 +-
drivers/gpu/drm/i915/display/intel_crtc.c | 37 ++++++++
drivers/gpu/drm/i915/display/intel_crtc.h | 9 ++
drivers/gpu/drm/i915/display/intel_display.c | 37 ++++----
drivers/gpu/drm/i915/display/intel_display.h | 24 +++++
.../drm/i915/display/intel_display_types.h | 72 +++------------
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
.../drm/i915/display/intel_dp_aux_backlight.c | 1 +
.../drm/i915/display/intel_dp_link_training.c | 2 +-
drivers/gpu/drm/i915/display/intel_dsi.c | 2 +
drivers/gpu/drm/i915/display/intel_fb.c | 11 +++
drivers/gpu/drm/i915/display/intel_fb.h | 2 +
drivers/gpu/drm/i915/display/intel_fb_pin.c | 10 +--
.../drm/i915/display/intel_plane_initial.c | 5 +-
drivers/gpu/drm/i915/display/intel_quirks.c | 1 +
drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +-
drivers/gpu/drm/i915/display/intel_tv.c | 7 +-
drivers/gpu/drm/i915/i915_drv.h | 88 +------------------
drivers/gpu/drm/i915/intel_pm_types.h | 76 ++++++++++++++++
20 files changed, 212 insertions(+), 184 deletions(-)
create mode 100644 drivers/gpu/drm/i915/intel_pm_types.h
--
2.30.2
next reply other threads:[~2021-11-22 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 13:51 Jani Nikula [this message]
2021-11-22 13:51 ` [Intel-gfx] [PATCH 1/8] drm/i915/display: use drm_crtc_wait_one_vblank() directly when possible Jani Nikula
2021-11-25 10:32 ` Ville Syrjälä
2021-11-22 13:51 ` [Intel-gfx] [PATCH 2/8] drm/i915/display: remove intel_wait_for_vblank() Jani Nikula
2021-11-25 10:23 ` Ville Syrjälä
2021-11-25 10:35 ` Ville Syrjälä
2021-11-25 11:03 ` Jani Nikula
2021-11-22 13:51 ` [Intel-gfx] [PATCH 3/8] drm/i915/crtc: un-inline some crtc functions and move to intel_crtc.[ch] Jani Nikula
2021-11-22 13:51 ` [Intel-gfx] [PATCH 4/8] drm/i915/fb: move intel_fb_uses_dpt to intel_fb.c and un-inline Jani Nikula
2021-11-22 13:51 ` [Intel-gfx] [PATCH 5/8] drm/i915: split out intel_pm_types.h Jani Nikula
2021-11-22 13:51 ` [Intel-gfx] [PATCH 6/8] drm/i915: move enum hpd_pin to intel_display.h Jani Nikula
2021-11-22 13:51 ` [Intel-gfx] [PATCH 7/8] drm/i915/display: convert dp_to_i915() to a macro Jani Nikula
2021-11-22 13:51 ` [Intel-gfx] [PATCH 8/8] drm/i915/display: stop including i915_drv.h from intel_display_types.h Jani Nikula
2021-11-22 18:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: break intel_display_types.h dependency on i915_drv.h Patchwork
2021-11-22 18:08 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-22 18:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-22 23:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1637588831.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox