Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 0/9] drm/edid: constify EDID parsing
Date: Fri, 25 Mar 2022 14:25:22 +0200	[thread overview]
Message-ID: <cover.1648210803.git.jani.nikula@intel.com> (raw)

Remove accidental (?) EDID modification while parsing, and constify EDID
in most places during EDID parsing.

In the future I'll want more clarity on who modifies the EDID and where,
and I'll want the compiler to help.

The EDID is still mutable in places that do validity checking and try to
fix it in the process. I'll probably want to split the two into separate
check and fix steps too, but that's for another series.

This is based on current drm-tip, without the CEA iterators work.


BR,
Jani.


Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Jani Nikula (9):
  drm/edid: don't modify EDID while parsing
  drm/edid: pass a timing pointer to is_display_descriptor()
  drm/edid: use struct detailed_timing member access in is_rb()
  drm/edid: use struct detailed_timing member access in gtf2 functions
  drm/edid: constify struct detailed_timing in lower level parsing
  drm/edid: constify struct detailed_timing in parsing callbacks
  drm/edid: constify struct edid passed to detailed blocks
  drm/edid: constify struct edid passed around in callbacks and closure
  drm/edid: add more general struct edid constness in the interfaces

 drivers/gpu/drm/drm_edid.c | 272 ++++++++++++++++++++-----------------
 include/drm/drm_edid.h     |  10 +-
 2 files changed, 153 insertions(+), 129 deletions(-)

-- 
2.30.2


             reply	other threads:[~2022-03-25 12:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 12:25 Jani Nikula [this message]
2022-03-25 12:25 ` [Intel-gfx] [PATCH 1/9] drm/edid: don't modify EDID while parsing Jani Nikula
2022-03-25 12:40   ` Ville Syrjälä
2022-03-25 12:25 ` [Intel-gfx] [PATCH 2/9] drm/edid: pass a timing pointer to is_display_descriptor() Jani Nikula
2022-03-25 12:49   ` Ville Syrjälä
2022-03-25 12:25 ` [Intel-gfx] [PATCH 3/9] drm/edid: use struct detailed_timing member access in is_rb() Jani Nikula
2022-03-25 13:06   ` Ville Syrjälä
2022-03-25 12:25 ` [Intel-gfx] [PATCH 4/9] drm/edid: use struct detailed_timing member access in gtf2 functions Jani Nikula
2022-03-25 12:25 ` [Intel-gfx] [PATCH 5/9] drm/edid: constify struct detailed_timing in lower level parsing Jani Nikula
2022-03-25 12:25 ` [Intel-gfx] [PATCH 6/9] drm/edid: constify struct detailed_timing in parsing callbacks Jani Nikula
2022-03-25 12:25 ` [Intel-gfx] [PATCH 7/9] drm/edid: constify struct edid passed to detailed blocks Jani Nikula
2022-03-25 12:25 ` [Intel-gfx] [PATCH 8/9] drm/edid: constify struct edid passed around in callbacks and closure Jani Nikula
2022-03-25 12:25 ` [Intel-gfx] [PATCH 9/9] drm/edid: add more general struct edid constness in the interfaces Jani Nikula
2022-03-25 13:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: constify EDID parsing Patchwork
2022-03-25 13:26 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-25 13:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-25 15:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1648210803.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox