Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v2 0/3] Improve drm printer code
Date: Wed, 22 May 2024 11:02:29 +0200	[thread overview]
Message-ID: <d638971e-0a63-4632-8500-63bc893e6d65@intel.com> (raw)
In-Reply-To: <20240517163406.2348-1-michal.wajdeczko@intel.com>

++

It's already reviewed, but since this touches shared code, extra acks
are still welcomed

On 17.05.2024 18:34, Michal Wajdeczko wrote:
> We already have some drm printk functions that need to duplicate
> a code to get a similar format of the final result, for example:
> 
>   [ ] 0000:00:00.0: [drm:foo] bar
>   [ ] 0000:00:00.0: [drm] foo bar
>   [ ] 0000:00:00.0: [drm] *ERROR* foo
> 
> Add a generic __drm_dev_vprintk() function that can format the
> final message like all other existing function do and allows us
> to keep the formatting code in one place.
> 
> Above also allows to improve drm_dbg_printer() that today lacks
> of outputing symbolic name of the caller, like drm_dbg() does.
> 
> v1: https://patchwork.freedesktop.org/series/133749/
> v2: make it static, keep it simple and use braces (Jani)
> 
> Michal Wajdeczko (3):
>   drm/print: Add generic drm dev printk function
>   drm/print: Improve drm_dbg_printer
>   drm/i915: Don't use __func__ as prefix for drm_dbg_printer
> 
>  drivers/gpu/drm/drm_print.c                | 53 ++++++++++++----------
>  drivers/gpu/drm/i915/gt/intel_reset.c      |  2 +-
>  drivers/gpu/drm/i915/gt/selftest_context.c |  2 +-
>  include/drm/drm_print.h                    |  2 +
>  4 files changed, 34 insertions(+), 25 deletions(-)
> 

      parent reply	other threads:[~2024-05-22  9:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 16:34 [PATCH v2 0/3] Improve drm printer code Michal Wajdeczko
2024-05-17 16:34 ` [PATCH v2 1/3] drm/print: Add generic drm dev printk function Michal Wajdeczko
2024-05-20  8:48   ` Jani Nikula
2024-05-17 16:34 ` [PATCH v2 2/3] drm/print: Improve drm_dbg_printer Michal Wajdeczko
2024-05-17 16:34 ` [PATCH v2 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer Michal Wajdeczko
2024-05-17 17:05 ` ✗ Fi.CI.CHECKPATCH: warning for Improve drm printer code (rev2) Patchwork
2024-05-17 17:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-17 17:17 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-18  3:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-22  9:02 ` Michal Wajdeczko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d638971e-0a63-4632-8500-63bc893e6d65@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox