Re: [PATCH v7 4/4] drm/i915: Add transcoder restriction to PSR2

["Souza, Jose" <jose.souza@intel.com>]

On Mon, 2019-08-12 at 19:20 +0530, Gupta, Anshuman wrote:
> 
> On 7/31/2019 4:17 AM, José Roberto de Souza wrote:
> > According to PSR2_CTL definition on BSpec there is only one
> > instance
> > of PSR2_CTL also ICL display overview state that PSR2 is only
> > supported in EDP transcoder, so now that is possible to have PSR in
> > any transcoder lets add this hardware restriction.
> > 
> > BSpec: 7713
> > BSpec: 20584
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >   drivers/gpu/drm/i915/display/intel_psr.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index f06b4a0b9e26..526990767c52 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -545,6 +545,11 @@ static bool intel_psr2_config_valid(struct
> > intel_dp *intel_dp,
> >   	if (!dev_priv->psr.sink_psr2_support)
> >   		return false;
> >   
> > +	if (crtc_state->cpu_transcoder != TRANSCODER_EDP) {
> > +		DRM_DEBUG_KMS("PSR2 is only supported in EDP
> > transcoder\n");
> > +		return false;
> > +	}
> > +
> TGL supports PSR2 on TRANSCODER_A, am i missing anything here?

That is right TGL support PSR2 on TRANSCODER_A, this series was being
sent before TGL was made public that is why this why only edp in here,
I will fix that in the next version but anyways there a few more PSR
patches to enable PSR on TGL.

> >   	/*
> >   	 * DSC and PSR2 cannot be enabled simultaneously. If a
> > requested
> >   	 * resolution requires DSC to be enabled, priority is given to
> > DSC
> > 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx