Re: [Intel-gfx] [PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

Hey Matt, apologies for the delay, went thru all the code, LGTM.

Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>

P.S. - As a side note, would be interesting to replay the original reason behind the overloading of the
func ptr bits to begin with... to see what the initial intention was.


...alan

On Wed, 2021-09-22 at 08:47 -0700, Matthew Brost wrote:
> Rather than stealing bits from i915_sw_fence function pointer use
> seperate fields for function pointer and flags. If using two different
> fields, the 4 byte alignment for the i915_sw_fence function pointer can
> also be dropped.
> 
> v2:
>  (CI)
>   - Set new function field rather than flags in __i915_sw_fence_init
> v3:
>  (Tvrtko)
>   - Remove BUG_ON(!fence->flags) in reinit as that will now blow up
>   - Only define fence->flags if CONFIG_DRM_I915_SW_FENCE_CHECK_DAG is
>     defined
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c  |  2 +-
>  drivers/gpu/drm/i915/gem/i915_gem_context.c   |  2 +-
>  drivers/gpu/drm/i915/i915_request.c           |  4 +--
>  drivers/gpu/drm/i915/i915_sw_fence.c          | 28 +++++++++++--------
>  drivers/gpu/drm/i915/i915_sw_fence.h          | 23 +++++++--------
>  drivers/gpu/drm/i915/i915_sw_fence_work.c     |  2 +-
>  .../gpu/drm/i915/selftests/i915_sw_fence.c    |  2 +-
>  drivers/gpu/drm/i915/selftests/lib_sw_fence.c |  8 +++---
>  8 files changed, 39 insertions(+), 32 deletions(-)
> 
>  
> -- 
> 2.32.0
>