intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/22] drm/i915/vrr: A few fixes and a bunch of cleanup
@ 2025-10-20 18:50 Ville Syrjala
  2025-10-20 18:50 ` [PATCH 01/22] drm/i915/vrr: Fix intel_vrr_always_use_vrr_tg()==true on TGL Ville Syrjala
                   ` (24 more replies)
  0 siblings, 25 replies; 49+ messages in thread
From: Ville Syrjala @ 2025-10-20 18:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: intel-xe

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

With all the recent work on the VRR code we've accumulated quite
a few slightly rough corners. Try to clean things up a bit.

While testing the cleanups I noticed a few real issues, fixes
for which are included at the start of the series.

Ville Syrjälä (22):
  drm/i915/vrr: Fix intel_vrr_always_use_vrr_tg()==true on TGL
  drm/i915/lrr: Include SCL in lrr_params_changed()
  drm/i915: Remove the "vblank delay" state dump
  drm/i915/vrr: Compute fixed refresh rate timings the sam way as CMRR
    timings
  drm/i915/vrr: Reorganize intel_vrr_compute_cmrr_timings() a bit
  drm/i195/vrr: Move crtc_state->vrr.{vmin,vmax} update into
    intel_vrr_compute_vrr_timings()
  drm/i915/vrr: Move compute_fixed_rr_timings()
  drm/i915/vrr: Extract intel_vrr_set_vrr_timings()
  drm/i915/vrr: Avoid redundant TRANS_PUSH write in intel_vrr_enable()
  drm/i915/vrr: Move EMP_AS_SDP_TL write into
    intel_vrr_set_transcoder_timings()
  drm/i915/vrr: Use trans_vrr_ctl() in intel_vrr_transcoder_disable()
  drm/i915/vrr: Extract intel_vrr_tg_disable()
  drm/i915/vrr: Extract intel_vrr_tg_enable()
  drm/i915/vrr: Disable VRR TG in intel_vrr_transcoder_disable() only on
    always use_vrr_tg() platforms
  drm/i915/vrr: Always write TRANS_VRR_CTL in
    intel_vrr_set_transcoder_timings() on !always_use_vrr_tg()
  drm/i915/vrr: Remove redundant HAS_VRR() checks
  drm/i915/vrr: Move HAS_VRR() check into
    intel_vrr_set_transcoder_timings()
  drm/i915/vrr: s/crtc_state/old_crtc_state/ in
    intel_vrr_transcoder_disable()
  drm/i915/vrr: Nuke intel_vrr_vblank_exit_length()
  drm/i915/vrr: Nuke intel_vrr_vmin_flipline()
  drm/i915/vrr: Update the intel_vrr_extra_vblank_delay() comment
  drm/i915/vrr: Check HAS_VRR() first in intel_vrr_is_capable()

 .../drm/i915/display/intel_crtc_state_dump.c  |   4 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  22 +-
 drivers/gpu/drm/i915/display/intel_vrr.c      | 212 ++++++++----------
 3 files changed, 113 insertions(+), 125 deletions(-)

-- 
2.49.1


^ permalink raw reply	[flat|nested] 49+ messages in thread

end of thread, other threads:[~2025-10-24 14:24 UTC | newest]

Thread overview: 49+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-20 18:50 [PATCH 00/22] drm/i915/vrr: A few fixes and a bunch of cleanup Ville Syrjala
2025-10-20 18:50 ` [PATCH 01/22] drm/i915/vrr: Fix intel_vrr_always_use_vrr_tg()==true on TGL Ville Syrjala
2025-10-24 13:24   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 02/22] drm/i915/lrr: Include SCL in lrr_params_changed() Ville Syrjala
2025-10-24 13:25   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 03/22] drm/i915: Remove the "vblank delay" state dump Ville Syrjala
2025-10-24 13:26   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 04/22] drm/i915/vrr: Compute fixed refresh rate timings the sam way as CMRR timings Ville Syrjala
2025-10-24 13:27   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 05/22] drm/i915/vrr: Reorganize intel_vrr_compute_cmrr_timings() a bit Ville Syrjala
2025-10-24 13:28   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 06/22] drm/i195/vrr: Move crtc_state->vrr.{vmin, vmax} update into intel_vrr_compute_vrr_timings() Ville Syrjala
2025-10-24 13:28   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 07/22] drm/i915/vrr: Move compute_fixed_rr_timings() Ville Syrjala
2025-10-24 13:29   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 08/22] drm/i915/vrr: Extract intel_vrr_set_vrr_timings() Ville Syrjala
2025-10-24 13:30   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 09/22] drm/i915/vrr: Avoid redundant TRANS_PUSH write in intel_vrr_enable() Ville Syrjala
2025-10-24 13:30   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 10/22] drm/i915/vrr: Move EMP_AS_SDP_TL write into intel_vrr_set_transcoder_timings() Ville Syrjala
2025-10-24 13:39   ` Nautiyal, Ankit K
2025-10-24 13:51     ` Ville Syrjälä
2025-10-20 18:50 ` [PATCH 11/22] drm/i915/vrr: Use trans_vrr_ctl() in intel_vrr_transcoder_disable() Ville Syrjala
2025-10-24 13:45   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 12/22] drm/i915/vrr: Extract intel_vrr_tg_disable() Ville Syrjala
2025-10-24 13:45   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 13/22] drm/i915/vrr: Extract intel_vrr_tg_enable() Ville Syrjala
2025-10-24 14:10   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 14/22] drm/i915/vrr: Disable VRR TG in intel_vrr_transcoder_disable() only on always use_vrr_tg() platforms Ville Syrjala
2025-10-24 14:10   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 15/22] drm/i915/vrr: Always write TRANS_VRR_CTL in intel_vrr_set_transcoder_timings() on !always_use_vrr_tg() Ville Syrjala
2025-10-24 14:11   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 16/22] drm/i915/vrr: Remove redundant HAS_VRR() checks Ville Syrjala
2025-10-24 14:12   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 17/22] drm/i915/vrr: Move HAS_VRR() check into intel_vrr_set_transcoder_timings() Ville Syrjala
2025-10-24 14:14   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 18/22] drm/i915/vrr: s/crtc_state/old_crtc_state/ in intel_vrr_transcoder_disable() Ville Syrjala
2025-10-24 14:17   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 19/22] drm/i915/vrr: Nuke intel_vrr_vblank_exit_length() Ville Syrjala
2025-10-24 14:18   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 20/22] drm/i915/vrr: Nuke intel_vrr_vmin_flipline() Ville Syrjala
2025-10-24 14:20   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 21/22] drm/i915/vrr: Update the intel_vrr_extra_vblank_delay() comment Ville Syrjala
2025-10-24 14:21   ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 22/22] drm/i915/vrr: Check HAS_VRR() first in intel_vrr_is_capable() Ville Syrjala
2025-10-24 14:23   ` Nautiyal, Ankit K
2025-10-21  0:33 ` ✓ i915.CI.BAT: success for drm/i915/vrr: A few fixes and a bunch of cleanup Patchwork
2025-10-21  8:21 ` [PATCH 00/22] " Jani Nikula
2025-10-21 15:21 ` ✗ i915.CI.Full: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).