From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add support of Tile4 to MTL
Date: Tue, 20 Dec 2022 23:23:17 +0200 [thread overview]
Message-ID: <dca1d107-a529-fea3-0d1f-ba33ea3bf881@gmail.com> (raw)
In-Reply-To: <20221220162926.22805-1-stanislav.lisovskiy@intel.com>
On 20.12.2022 18.29, Stanislav Lisovskiy wrote:
> We have some Tile4 tests now skipping, which were
> supposed to be working. So lets make them work, by
> adding display_ver 14 as supported.
>
> v2: - Remove "14" for Tile 4 CCS formats, as they
> seem to be not supported by DG2(Juha-Pekka Heikkila)
DG2 ccs modifiers not supported on MTL. DG2 ccs modifiers are of course
supported on DG2.
> - For generic Tile 4, the opposite - lets use -1
> in order to make sure all the next gens support it by
> default(Juha-Pekka Heikkila)
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 63137ae5ab217..93d0e46e54813 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -174,7 +174,7 @@ static const struct intel_modifier_desc intel_modifiers[] = {
> .plane_caps = INTEL_PLANE_CAP_TILING_4 | INTEL_PLANE_CAP_CCS_RC,
> }, {
> .modifier = I915_FORMAT_MOD_4_TILED,
> - .display_ver = { 13, 13 },
> + .display_ver = { 13, -1 },
> .plane_caps = INTEL_PLANE_CAP_TILING_4,
> }, {
> .modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS,
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
next prev parent reply other threads:[~2022-12-20 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 16:29 [Intel-gfx] [PATCH] drm/i915/mtl: Add support of Tile4 to MTL Stanislav Lisovskiy
2022-12-20 21:23 ` Juha-Pekka Heikkila [this message]
2022-12-22 0:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add support of Tile4 to MTL (rev2) Patchwork
2022-12-22 3:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-12-19 13:50 [Intel-gfx] [PATCH] drm/i915/mtl: Add support of Tile4 to MTL Stanislav Lisovskiy
2022-12-19 18:27 ` Juha-Pekka Heikkila
2022-12-20 10:13 ` Lisovskiy, Stanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca1d107-a529-fea3-0d1f-ba33ea3bf881@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox