Re: [Intel-gfx] [PATCH 2/2] Revert "drm/i915/display/psr: Do full fetch when handling multi-planar formats"

["Souza, Jose" <jose.souza@intel.com>]

On Thu, 2021-10-21 at 13:10 +0300, Jouni Högander wrote:
> This reverts commit 1f61f0655b95d5b89589390e6f83c4a61d9b1e8d.
> 
> Now we are supporting selective fetch for biplanar formats. We can revert WA
> patch which forced using full fetch for biplanar formats.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 469bf95178f3..65282a545dbf 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1571,9 +1571,6 @@ static void intel_psr2_sel_fetch_pipe_alignment(const struct intel_crtc_state *c
>   * also planes are not updated if they have a negative X
>   * position so for now doing a full update in this cases
>   *
> - * TODO: We are missing multi-planar formats handling, until it is
> - * implemented it will send full frame updates.
> - *
>   * Plane scaling and rotation is not supported by selective fetch and both
>   * properties can change without a modeset, so need to be check at every
>   * atomic commmit.
> @@ -1583,7 +1580,6 @@ static bool psr2_sel_fetch_plane_state_supported(const struct intel_plane_state
>  	if (plane_state->uapi.dst.y1 < 0 ||
>  	    plane_state->uapi.dst.x1 < 0 ||
>  	    plane_state->scaler_id >= 0 ||
> -	    plane_state->hw.fb->format->num_planes > 1 ||
>  	    plane_state->uapi.rotation != DRM_MODE_ROTATE_0)
>  		return false;
>