Re: [PATCH] drm/i915/dp: use EXPORT_SYMBOL_IF_KUNIT() for kunit helpers

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 16 Sep 2026, Imre Deak <imre.deak@intel.com> wrote:
> On Wed, Sep 16, 2026 at 10:27:52AM +0300, Jani Nikula wrote:
>> On Wed, 16 Sep 2026, Imre Deak <imre.deak@intel.com> wrote:
>> > On Tue, Sep 15, 2026 at 09:48:14PM +0300, Imre Deak wrote:
>> >> On Tue, Sep 15, 2026 at 07:06:20PM +0300, Jani Nikula wrote:
>> >> > Use EXPORT_SYMBOL_IF_KUNIT() instead of the regular EXPORT_SYMBOL() to
>> >> > export the symbols to the kunit namespace. Otherwise, the symbols get
>> >> > exported for all the kernel to see, and the corresponding
>> >> > MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING") in the tests is
>> >> > meaningless.
>> >> 
>> >> Yes, these symblols are only used by kunit, so no need to export them
>> >> otherwise. Should've thought about it while typing the above
>> >> MODULE_IMPORT_NS():
>> >> 
>> >> Reviewed-by: Imre Deak <imre.deak@intel.com>
>> >
>> > Actually, the symbols are defined and exported only if KUNIT is enabled
>> > without this patch already, as both of these are in an
>> > IS_ENABLED(CONFIG_KUNIT) block.
>> 
>> That only gates whether they're exported or not. The change is about
>> exporting them to the kunit namespace when they're exported.
>
> Right, so in a kunit build the visibility of symbols was still too
> broad. The R-b still applies.

Thanks, pushed!

BR,
Jani.

-- 
Jani Nikula, Intel