From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC 3/5] drm/i915: split out virtual engine code
Date: Wed, 11 Dec 2019 13:34:20 -0800 [thread overview]
Message-ID: <de7d8199-70b8-9a69-1e84-a6b55f3a43ee@intel.com> (raw)
In-Reply-To: <157609936238.27099.9225483018528537974@skylake-alporthouse-com>
On 12/11/19 1:22 PM, Chris Wilson wrote:
> Quoting Daniele Ceraolo Spurio (2019-12-11 21:12:42)
>> Having the virtual engine handling in its own file will make it easier
>> call it from or modify for the GuC implementation without leaking the
>> changes in the context management or execlists submission paths.
>
> No. The virtual engine is tightly coupled into the execlists, it is not
> the starting point for a general veng.
> -Chris
>
What's the issue from your POV? We've been using it with little changes
for GuC submission and IMO it flows relatively well, mainly just using a
different tasklet and slightly different cops (need to call into GuC for
pin/unpin).
Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-11 21:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:12 [Intel-gfx] [RFC 0/5] Split up intel_lrc.c Daniele Ceraolo Spurio
2019-12-11 21:12 ` [Intel-gfx] [RFC 1/5] drm/i915: introduce logical_ring and lr_context naming Daniele Ceraolo Spurio
2019-12-11 21:20 ` Chris Wilson
2019-12-11 21:33 ` Chris Wilson
2019-12-11 22:04 ` Daniele Ceraolo Spurio
2019-12-11 23:35 ` Matthew Brost
2019-12-11 21:12 ` [Intel-gfx] [RFC 2/5] drm/i915: Move struct intel_virtual_engine to its own header Daniele Ceraolo Spurio
2019-12-11 21:22 ` Chris Wilson
2019-12-11 21:12 ` [Intel-gfx] [RFC 3/5] drm/i915: split out virtual engine code Daniele Ceraolo Spurio
2019-12-11 21:22 ` Chris Wilson
2019-12-11 21:34 ` Daniele Ceraolo Spurio [this message]
2019-12-11 23:09 ` Matthew Brost
2019-12-11 21:12 ` [Intel-gfx] [RFC 4/5] drm/i915: move execlists selftests to their own file Daniele Ceraolo Spurio
2019-12-11 21:26 ` Chris Wilson
2019-12-11 22:07 ` Daniele Ceraolo Spurio
2019-12-11 21:12 ` [Intel-gfx] [RFC 5/5] drm/i915: introduce intel_execlists_submission.<c/h> Daniele Ceraolo Spurio
2019-12-11 21:31 ` Chris Wilson
2019-12-11 22:35 ` Daniele Ceraolo Spurio
2019-12-12 1:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Split up intel_lrc.c Patchwork
2019-12-12 1:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-12 12:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de7d8199-70b8-9a69-1e84-a6b55f3a43ee@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox