From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: Reconfigurable OA queries
Date: Wed, 9 Oct 2019 09:40:54 +0300 [thread overview]
Message-ID: <e33de237-4b8f-8efa-bf18-a0f5d0583cfe@intel.com> (raw)
In-Reply-To: <157057718910.16129.12259740531839959143@skylake-alporthouse-com>
On 09/10/2019 02:26, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2019-10-09 00:14:41)
>> On 09/10/2019 00:40, Chris Wilson wrote:
>>> This is Lionel's work to enable OA for Vulkan, greatly bastardised on
>>> top of the struct_mutex removal. It claims to be doing the right
>>> thing...
>>> -Chris
>>>
>>>
>> Thanks a lot of picking this up.
>>
>> I'm aware of an issue with patch 9 as I can see requests with perf
>> queries being preempted. Looking into that, but not quite there yet.
> Outside of the masking issue where a later request on the same context
> will mask the nopreempt request, if that nopreempt flag is set on the
> last submitted request to ELSP[0], we will not allow that context to be
> preempted before we consider the request to be completed.
Oh... interesting!
>
>> I think there is a dependency issue with patch 8. We also use
>> cliprects_ptr for fences.
> Hmm, I was expecting the flag validation to be in the first patch to add
> extension parsing, but we are missing the test if both flags are set,
> reject the execbuf.
>
>> If we start reusing it for extended parameters, we need to make fences
>> the first extended param.
> Why?
> -Chris
>
How do we pass a reconfigure of OA together with an array of fences?
-Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-09 6:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 21:40 Reconfigurable OA queries Chris Wilson
2019-10-08 21:40 ` [PATCH 1/9] drm/i915/perf: store the associated engine of a stream Chris Wilson
2019-10-08 21:40 ` [PATCH 2/9] drm/i915/perf: introduce a versioning of the i915-perf uapi Chris Wilson
2019-10-08 21:40 ` [PATCH 3/9] drm/i915/perf: allow for CS OA configs to be created lazily Chris Wilson
2019-10-08 21:40 ` [PATCH 4/9] drm/i915: add support for perf configuration queries Chris Wilson
2019-10-08 21:40 ` [PATCH 5/9] drm/i915/perf: implement active wait for noa configurations Chris Wilson
2019-10-08 21:40 ` [PATCH 6/9] drm/i915/perf: execute OA configuration from command stream Chris Wilson
2019-10-08 21:40 ` [PATCH 7/9] drm/i915: introduce a mechanism to extend execbuf2 Chris Wilson
2019-10-08 21:40 ` [PATCH 8/9] drm/i915: add a new perf configuration execbuf parameter Chris Wilson
2019-10-08 21:40 ` [PATCH 9/9] drm/i915/perf: allow holding preemption on filtered ctx Chris Wilson
2019-10-08 22:38 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915/perf: store the associated engine of a stream Patchwork
2019-10-08 23:02 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-08 23:14 ` Reconfigurable OA queries Lionel Landwerlin
2019-10-08 23:26 ` Chris Wilson
2019-10-09 6:40 ` Lionel Landwerlin [this message]
2019-10-09 6:50 ` Chris Wilson
2019-10-09 7:47 ` Lionel Landwerlin
2019-10-09 11:38 ` Lionel Landwerlin
2019-10-09 6:42 ` Lionel Landwerlin
2019-10-09 6:10 ` ✓ Fi.CI.IGT: success for series starting with [1/9] drm/i915/perf: store the associated engine of a stream Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e33de237-4b8f-8efa-bf18-a0f5d0583cfe@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox