Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/i915: add warning for unidle GPU
Date: Sun, 25 Sep 2011 12:15:18 +0100	[thread overview]
Message-ID: <e39f63$23743r@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20110925101636.GB2852@phenom.ffwll.local>

On Sun, 25 Sep 2011 12:16:36 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> Also it looks like this causes us to no properly idle the gpu on
> suspend/resume. Might fix issues especially on gen2/3 where we put an
> MI_WAIT in front of the flip, hence enlarging the window to up to 20 ms.

This I happen to disagree with as there is an existing bug with not
properly quiescing the GPU (on all gen) when disabling pipes that would
also be hit in this case.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2011-09-25 11:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-24 22:23 [PATCH v2 0/4] Ironlake mobile GPU with VT-d, fix Ben Widawsky
2011-09-24 22:23 ` [PATCH v2 1/4] drm/i915: add warning for unidle GPU Ben Widawsky
2011-09-25 10:16   ` Daniel Vetter
2011-09-25 11:15     ` Chris Wilson [this message]
2011-09-24 22:23 ` [PATCH v2 2/4] drm/i915: Ironlake mobile GPU with VT-d fix Ben Widawsky
2011-09-24 22:41   ` Ben Widawsky
2011-09-25  9:40   ` Daniel Vetter
2011-09-25 23:42     ` Ben Widawsky
2011-09-26  7:23       ` Daniel Vetter
2011-10-15  2:08         ` Ben Widawsky
2011-09-24 22:23 ` [PATCH v2 3/4] intel-iommu: IOTLB hang workaround Ben Widawsky
2011-09-24 22:23 ` [PATCH v2 4/4] drm/i915: add unidle warning back Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='e39f63$23743r@fmsmga002.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox