From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>, Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: FBC patchset
Date: Tue, 17 Jan 2012 16:57:03 +0000 [thread overview]
Message-ID: <e39f63$3bvohl@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20120117161817.GP4093@phenom.ffwll.local>
On Tue, 17 Jan 2012 17:18:17 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> I've just noticed that we seem to miss this plug to fix fbc issues. Care
> to resend a proper patch in case we still need this?
>
> Also, I we could try to also disable fbc when we detect frontbuffer
> rendering (and generally abolish setting up the fence to detect such
> writes), maybe that helps with our fbc troubles (if it's actually worth
> it). Eugeni?
I'm testing whether disabling fbc when fb is busy helps on my
troublesome SNB. But X can and will still access the scanout through a
fence, so we can't simply abolish setting up fences here. The other
recourse is to always used a shadow buffer so that we never access the
scanout directly, and perhaps restrict that to only use render as well.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-01-17 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 11:22 FBC patchset Chris Wilson
2011-07-08 11:22 ` [PATCH 1/8] drm/i915: Only export the generic intel_disable_fbc() interface Chris Wilson
2011-07-08 11:22 ` [PATCH 2/8] drm/i915: Replace direct calls to vfunc.disable_fbc with intel_disable_fbc() Chris Wilson
2011-07-08 11:22 ` [PATCH 3/8] drm/i915: Remove vestigial pitch from post-gen2 FBC control routines Chris Wilson
2011-07-08 17:20 ` Keith Packard
2011-07-08 11:22 ` [PATCH 4/8] drm/i915: Use of a CPU fence is mandatory to update FBC regions upon CPU writes Chris Wilson
2011-07-08 11:22 ` [PATCH 5/8] drm/i915: Set persistent-mode for ILK/SNB framebuffer compression Chris Wilson
2011-07-08 11:22 ` [PATCH 6/8] drm/i915: Disable FBC across page-flipping Chris Wilson
2011-07-08 11:22 ` [PATCH 7/8] drm/i915: Perform intel_enable_fbc() from a delayed task Chris Wilson
2011-07-08 11:22 ` [PATCH 8/8] drm/i915: Share the common work of disabling active FBC before updating Chris Wilson
2011-07-08 19:43 ` FBC patchset Chris Wilson
2011-07-08 20:00 ` Keith Packard
2011-07-08 20:19 ` Chris Wilson
2011-07-08 21:28 ` Keith Packard
2011-07-08 22:08 ` Chris Wilson
2012-01-17 16:18 ` Daniel Vetter
2012-01-17 16:57 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$3bvohl@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=eugeni@dodonov.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox