From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: catch gtfifo errors on forcewake_put
Date: Fri, 03 Feb 2012 23:10:09 +0000 [thread overview]
Message-ID: <e39f63$3iucdj@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1328308301-28304-2-git-send-email-ben@bwidawsk.net>
On Fri, 3 Feb 2012 14:31:41 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> This is similar to a patch I wrote several months ago. It's been updated
> for the new FORCEWAKE_MT, and it also no longer clears the debug
> register as it may be helpful to get that for the error state. Also
> recommended by Chris Wilson, use WARN() instead of DRM_ERROR, so we can
> get a backtrace.
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Can we use the read of GTFIFODBG in place of the POSTING_READ? And do we
really need to watch all the GTFIFODBG reads in the trace, or can I
squelch that noise with a I915_READ_NOTRACE?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-03 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 22:31 [PATCH 1/2] drm/i915: gtfifodbg in error state Ben Widawsky
2012-02-03 22:31 ` [PATCH 2/2] drm/i915: catch gtfifo errors on forcewake_put Ben Widawsky
2012-02-03 23:10 ` Chris Wilson [this message]
2012-02-04 2:15 ` Ben Widawsky
2012-02-04 10:59 ` Chris Wilson
2012-02-03 23:07 ` [PATCH 1/2] drm/i915: gtfifodbg in error state Chris Wilson
2012-02-04 12:54 ` Eugeni Dodonov
2012-02-04 19:48 ` [PATCH 2/2 v2] drm/i915: catch gtfifo errors on forcewake_put Ben Widawsky
2012-02-07 9:32 ` Daniel Vetter
2012-02-07 9:28 ` [PATCH 1/2] drm/i915: gtfifodbg in error state Daniel Vetter
2012-02-07 9:31 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$3iucdj@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox