From: John Harrison <john.c.harrison@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: <IGT-Dev@lists.freedesktop.org>,
<Intel-GFX@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Slawomir Milczarek <slawomir.milczarek@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table
Date: Thu, 16 Sep 2021 10:27:41 -0700 [thread overview]
Message-ID: <e4f66112-8628-0870-81a3-622838cdd86a@intel.com> (raw)
In-Reply-To: <YUMHcIsB1+9UmWKV@platvala-desk.ger.corp.intel.com>
On 9/16/2021 01:59, Petri Latvala wrote:
> On Wed, Sep 15, 2021 at 02:55:58PM -0700, John.C.Harrison@Intel.com wrote:
>> From: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>
>> Newer platforms have an embedded table giving details about that
>> platform's hardware configuration. This table can be retrieved from
>> the KMD via the existing query API. So add a test for it as both an
>> example of how to fetch the table and to validate the contents as much
>> as is possible.
>>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> Cc: Slawomir Milczarek <slawomir.milczarek@intel.com>
>> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>> ---
>> include/drm-uapi/i915_drm.h | 1 +
>> lib/intel_hwconfig_types.h | 106 +++++++++++++++++++++++
>> tests/i915/i915_query.c | 168 ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 275 insertions(+)
>> create mode 100644 lib/intel_hwconfig_types.h
>>
>> diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
>> index b9632bb2c..ae0c8dfad 100644
>> --- a/include/drm-uapi/i915_drm.h
>> +++ b/include/drm-uapi/i915_drm.h
>> @@ -2451,6 +2451,7 @@ struct drm_i915_query_item {
>> #define DRM_I915_QUERY_ENGINE_INFO 2
>> #define DRM_I915_QUERY_PERF_CONFIG 3
>> #define DRM_I915_QUERY_MEMORY_REGIONS 4
>> +#define DRM_I915_QUERY_HWCONFIG_TABLE 5
>> /* Must be kept compact -- no holes and well documented */
> Please update i915_drm.h with a copy from the kernel and state in the
> commit message which kernel commit sha it's from. If this change is
> not in the kernel yet, add this token to lib/i915/i915_drm_local.h
> instead.
>
>
Neither side is merged yet. My understanding is that all sides need to
be posted in parallel for CI to work. Once green and reviewed, the
kernel side gets merged first. Then the IGT/UMD patches get updated with
the official kernel headers, reposted and then merged.
John.
next prev parent reply other threads:[~2021-09-16 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 21:55 [Intel-gfx] [PATCH i-g-t 0/1] Add test for new hw info query John.C.Harrison
2021-09-15 21:55 ` [Intel-gfx] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table John.C.Harrison
2021-09-16 8:59 ` [Intel-gfx] [igt-dev] " Petri Latvala
2021-09-16 17:27 ` John Harrison [this message]
2021-09-17 8:37 ` Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2021-07-27 0:28 [Intel-gfx] [PATCH i-g-t 0/1] Add tests for new hw info query John.C.Harrison
2021-07-27 0:28 ` [Intel-gfx] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table John.C.Harrison
2021-09-15 3:47 ` [Intel-gfx] [igt-dev] " Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f66112-8628-0870-81a3-622838cdd86a@intel.com \
--to=john.c.harrison@intel.com \
--cc=IGT-Dev@lists.freedesktop.org \
--cc=Intel-GFX@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=petri.latvala@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=slawomir.milczarek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox