From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
<intel-gfx@lists.freedesktop.org>
Cc: <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3 2/3] drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate
Date: Mon, 18 Nov 2024 13:30:03 +0530 [thread overview]
Message-ID: <e5edb88d-71b2-47c4-845f-b136f6133ce1@intel.com> (raw)
In-Reply-To: <20241021105100.2861830-3-mitulkumar.ajitkumar.golani@intel.com>
On 10/21/2024 4:20 PM, Mitul Golani wrote:
> While running with fixed refresh rate and VRR timing generator set FAVT
> mode (Fixed Vtotal) in DP Adaptive Sync SDP to intimate the panel
> about Fixed refresh rate.
This is not matching with change below.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7e04913bc2ff..b1f68fff524d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2785,7 +2785,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
> as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode);
> as_sdp->target_rr_divider = true;
> } else {
> - as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL;
> + as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
This is done in patch :
https://patchwork.freedesktop.org/patch/623895/?series=134383&rev=6
Perhaps we can include this as part of this series?
Regards,
Ankit
> as_sdp->vtotal = adjusted_mode->vtotal;
> as_sdp->target_rr = 0;
> }
next prev parent reply other threads:[~2024-11-18 8:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 10:50 [PATCH v3 0/3] Add AS_SDP to fastset Mitul Golani
2024-10-21 10:50 ` [PATCH v3 1/3] drm/i915/vrr: Update vrr.vsync_{start, end} computation Mitul Golani
2024-10-29 2:58 ` Golani, Mitulkumar Ajitkumar
2024-11-18 7:55 ` [PATCH v3 1/3] drm/i915/vrr: Update vrr.vsync_{start,end} computation Nautiyal, Ankit K
2024-11-20 5:57 ` Golani, Mitulkumar Ajitkumar
2024-10-21 10:50 ` [PATCH v3 2/3] drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate Mitul Golani
2024-11-18 8:00 ` Nautiyal, Ankit K [this message]
2024-11-20 6:22 ` Golani, Mitulkumar Ajitkumar
2024-10-21 10:51 ` [PATCH v3 3/3] drm/i915/dp: Compute as_sdp based on if vrr possible Mitul Golani
2024-11-18 8:07 ` Nautiyal, Ankit K
2024-11-20 6:23 ` Golani, Mitulkumar Ajitkumar
2024-10-21 11:26 ` ✗ Fi.CI.SPARSE: warning for Add AS_SDP to fastset (rev2) Patchwork
2024-10-21 11:37 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-22 8:18 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-22 9:16 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-22 17:41 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5edb88d-71b2-47c4-845f-b136f6133ce1@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox