From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Rob Clark <robdclark@chromium.org>
Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field
Date: Tue, 23 May 2023 10:36:08 +0100 [thread overview]
Message-ID: <e6b80f3e-8734-9362-a38f-d35d108366a2@linux.intel.com> (raw)
In-Reply-To: <CAJs_Fx4tPYkPo-Oc2BduuzC09OfkB3PbFwBQ3b7U9rG_Akh_Fw@mail.gmail.com>
On 15/05/2023 15:14, Rob Clark wrote:
> On Mon, May 15, 2023 at 6:36 AM Tvrtko Ursulin
> <tvrtko.ursulin@linux.intel.com> wrote:
>>
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Rob,
>>
>> I thought maybe when you add memory stats the same field order like top(1)
>> would feel more natural? That is client name comes last and is left justified.
>> All other stats then come in the middle, between PID and NAME.
>>
>> DRM minor 0
>> PID render copy video video-enhance NAME
>> 2704 |▌ || || || | kwin_x11
>> 2734 |▏ || || || | plasmashell
>> 3932 | || || || | krunner
>> 4414 | || || || | xdg-desktop-por
>> 1999477 | || || || | firefox
>> 2162094 | || || || | thunderbir
>
> Seems like a good idea, and more in line with top/htop/nvtop
A-b/R-b? Or you go ahead with meminfo changes and I can rebase this on
top later. I am okay either way.
Regards,
Tvrtko
> BR,
> -R
>
>> intel-gpu-top: Intel Alderlake_s (Gen12) @ /dev/dri/card0 - 15/ 15 MHz
>> 99% RC6; 0.01/ 5.46 W; 34 irqs/s
>>
>> ENGINES BUSY MI_SEMA MI_WAIT
>> Render/3D 1.31% |▌ | 0% 0%
>> Blitter 0.00% | | 0% 0%
>> Video 0.00% | | 0% 0%
>> VideoEnhance 0.00% | | 0% 0%
>>
>> PID Render/3D Blitter Video VideoEnhance NAME
>> 2734 |▏ || || || | plasmashell
>> 2704 |▏ || || || | kwin_x11
>> 1837 |▏ || || || | Xorg
>> 3429732 | || || || | kwrite
>> 2162094 | || || || | thunderbird
>>
>> Cc: Rob Clark <robdclark@chromium.org>
>>
>> Tvrtko Ursulin (2):
>> gputop: Move client name last
>> intel_gpu_top: Move client name last
>>
>> tools/gputop.c | 19 +++++++++----------
>> tools/intel_gpu_top.c | 19 +++++++++----------
>> 2 files changed, 18 insertions(+), 20 deletions(-)
>>
>> --
>> 2.37.2
>>
prev parent reply other threads:[~2023-05-23 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 13:36 [Intel-gfx] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Tvrtko Ursulin
2023-05-15 13:36 ` [Intel-gfx] [PATCH i-g-t 1/2] gputop: Move client name last Tvrtko Ursulin
2023-05-23 10:50 ` Kamil Konieczny
2023-05-15 13:36 ` [Intel-gfx] [PATCH i-g-t 2/2] intel_gpu_top: " Tvrtko Ursulin
2023-05-23 10:51 ` Kamil Konieczny
2023-05-24 13:10 ` Tvrtko Ursulin
2023-05-15 14:14 ` [Intel-gfx] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field Rob Clark
2023-05-23 9:36 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b80f3e-8734-9362-a38f-d35d108366a2@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox