From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v14 1/6] drm/i915: store all subslice masks
Date: Fri, 23 Feb 2018 13:47:46 +0000 [thread overview]
Message-ID: <e783a09e-9487-ea3d-506c-0ebdb5923630@intel.com> (raw)
In-Reply-To: <20180222175359.16402-2-lionel.g.landwerlin@intel.com>
On 22/02/18 17:53, Lionel Landwerlin wrote:
> +static inline u16 sseu_get_eus(const struct sseu_dev_info *sseu,
> + int slice, int subslice)
> +{
> + int i, offset = sseu_eu_idx(sseu, slice, subslice);
> + u16 eu_mask = 0;
> +
> + for (i = 0;
> + i < DIV_ROUND_UP(sseu->max_eus_per_subslice, BITS_PER_BYTE); i++) {
> + eu_mask = ((u16) sseu->eu_mask[offset + i]) <<
> + (i * BITS_PER_BYTE);
Found a bug here (only affecting HSW with 10EUs per half-slice).
Should be eu_mask |= ...
> + }
> +
> + return eu_mask;
> +}
> +
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-23 13:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 17:53 [PATCH v14 0/6] drm/i915: expose RCS topology to userspace Lionel Landwerlin
2018-02-22 17:53 ` [PATCH v14 1/6] drm/i915: store all subslice masks Lionel Landwerlin
2018-02-23 13:47 ` Lionel Landwerlin [this message]
2018-02-22 17:53 ` [PATCH v14 2/6] drm/i915/debugfs: reuse max slice/subslices already stored in sseu Lionel Landwerlin
2018-02-22 17:53 ` [PATCH v14 3/6] drm/i915/debugfs: add rcs topology entry Lionel Landwerlin
2018-02-22 17:53 ` [PATCH v14 4/6] drm/i915: add rcs topology to error state Lionel Landwerlin
2018-02-22 17:53 ` [PATCH v14 5/6] drm/i915: add query uAPI Lionel Landwerlin
2018-03-05 14:54 ` Joonas Lahtinen
2018-03-05 15:03 ` Lionel Landwerlin
2018-02-22 17:53 ` [PATCH v14 6/6] drm/i915: expose rcs topology through " Lionel Landwerlin
2018-03-05 15:48 ` Joonas Lahtinen
2018-02-22 18:07 ` ✗ Fi.CI.SPARSE: warning for drm/i915: expose RCS topology to userspace Patchwork
2018-02-22 18:20 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-22 19:08 ` [PATCH v14 0/6] " Lionel Landwerlin
2018-02-23 0:33 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e783a09e-9487-ea3d-506c-0ebdb5923630@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox