Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Liou, Mei Fan" <mei.fan.liou@intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Dutta, Ranjan" <ranjan.dutta@intel.com>,
	"Chang, Junxiao" <junxiao.chang@intel.com>,
	ville.syrjala@linux.intel.com, "Deak, Imre" <imre.deak@intel.com>
Subject: RE: [PATCH] drm/i915: add disable_edp module parameter to skip phantom eDP init
Date: Thu, 02 Jul 2026 14:48:47 +0300	[thread overview]
Message-ID: <ec41ece75ff57c7641cc13d42588355efe0c00f4@intel.com> (raw)
In-Reply-To: <SA1PR11MB71300AD7CBCA15C7E410E852D8F52@SA1PR11MB7130.namprd11.prod.outlook.com>


Cc: Ville, Imre

On Thu, 02 Jul 2026, "Liou, Mei Fan" <mei.fan.liou@intel.com> wrote:
> Rather than adding a new module parameter or DMI quirk, I would like
> to pursue your suggestion of fixing the existing video=eDP-1:d path
> (tested: not working for this case).
> May I rework that?

I had a glance.

intel_dp_init_connector() -> drm_connector_init_with_ddc() ->
drm_connector_init_and_add() -> drm_connector_init_only() ->
drm_connector_get_cmdline_mode() ->
drm_mode_parse_command_line_for_connector() ->
drm_mode_parse_cmdline_extra().

drm_mode_parse_cmdline_extra() sets mode->force.

drm_connector_get_cmdline_mode() sets connector->force if mode->force.

It's an interesting idea to use connector->force == DRM_FORCE_OFF to
bail out from eDP init in a way that cleans up the eDP connector but
doesn't fail the probe altogether. (And I think currently this happens
automatically if the PPS/AUX fail, it just takes a while.)

For other connectors we should keep it dynamic, i.e. the connector
should stay around even if forced off at probe, as the status may change
later, but eDP is kind of static. E.g. we don't try all the DPCD reads
again later.

I'm not dismissing the idea immediately, and it might work, but I'm also
not pre-emptively acking. There may be corner cases that I can't think
of right now. Maybe we need to keep the connector around but just not
try to probe it, and then leave it disconnected. Not sure.


BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2026-07-02 11:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 10:28 [PATCH] drm/i915: add disable_edp module parameter to skip phantom eDP init mei.fan.liou
2026-06-30 10:47 ` Jani Nikula
2026-07-02 11:07   ` Liou, Mei Fan
2026-07-02 11:48     ` Jani Nikula [this message]
2026-06-30 13:47 ` ✓ i915.CI.BAT: success for " Patchwork
2026-06-30 23:13 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec41ece75ff57c7641cc13d42588355efe0c00f4@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=junxiao.chang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mei.fan.liou@intel.com \
    --cc=ranjan.dutta@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox