From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915: Always clear semaphore mboxes on seqno wrap
Date: Mon, 17 Dec 2012 19:15:40 +0000 [thread overview]
Message-ID: <eeac1e$5dimc7@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1355762669-6806-2-git-send-email-mika.kuoppala@intel.com>
On Mon, 17 Dec 2012 18:44:27 +0200, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> We need to clear the hw semaphore values explicitly.
> Even if sync_seqnos are zero, there might still be
> invalid values in the hw semaphores when we wrap.
This changelog does not make it clear why you want this patch. This is
for enabling a future feature, right?
Anyway, after initial misgivings because I thought you were trying to
fix a bug rather than add a feature, and provided that you improve the
changelog,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-17 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 16:44 [PATCH 1/4] drm/i915: Initialize hardware semaphore state on ring init Mika Kuoppala
2012-12-17 16:44 ` [PATCH 2/4] drm/i915: Always clear semaphore mboxes on seqno wrap Mika Kuoppala
2012-12-17 19:15 ` Chris Wilson [this message]
2012-12-18 14:19 ` Mika Kuoppala
2012-12-18 14:29 ` Chris Wilson
2012-12-17 16:44 ` [PATCH 3/4] drm/i915: Introduce i915_gem_seqno_init Mika Kuoppala
2012-12-17 16:44 ` [PATCH 4/4] drm/i915: Make next_seqno debugs entry to use i915_gem_seqno_init Mika Kuoppala
2012-12-17 19:13 ` Chris Wilson
2012-12-18 14:32 ` Mika Kuoppala
2012-12-18 14:47 ` Chris Wilson
2012-12-18 15:49 ` Mika Kuoppala
2012-12-17 19:17 ` Chris Wilson
2012-12-18 14:33 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eeac1e$5dimc7@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox