From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi@freedesktop.org" <Vivi@freedesktop.org>,
"Winkler, Tomas" <tomas.winkler@intel.com>
Subject: Re: [Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp
Date: Thu, 19 Jan 2023 23:01:14 +0000 [thread overview]
Message-ID: <f121bb857da18a50041328664397201587e66ddd.camel@intel.com> (raw)
In-Reply-To: <Y8mZGMjjlTW3U0jA@intel.com>
Thanks for reviewing the patch. I will fix the code according to your recommendation.
I assume we could probably go with -ENOLINK as the error (instead of -ENOMEM).
However, i'll wait for Alexander to respond on whether he needs drm_WARN_ON and your question on RPM.
...alan
On Thu, 2023-01-19 at 14:25 -0500, Vivi, Rodrigo wrote:
> On Thu, Jan 12, 2023 at 05:18:46PM -0800, Alan Previn wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > Add device link with i915 as consumer and mei_pxp as supplier
> > to ensure proper ordering of power flows.
> >
> > V2: condition on absence of heci_pxp to filter out DG
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > ---
> > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
Alan: [snip]
next prev parent reply other threads:[~2023-01-19 23:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 1:18 [Intel-gfx] [PATCH v5 0/6] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown Alan Previn
2023-01-13 1:18 ` [Intel-gfx] [PATCH v5 1/6] mei: mei-me: resume device in prepare Alan Previn
2023-01-18 11:42 ` Winkler, Tomas
2023-01-13 1:18 ` [Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp Alan Previn
2023-01-19 19:25 ` Rodrigo Vivi
2023-01-19 23:01 ` Teres Alexis, Alan Previn [this message]
2023-01-22 6:57 ` Usyskin, Alexander
2023-01-23 12:43 ` Jani Nikula
2023-01-23 14:31 ` Rodrigo Vivi
2023-01-24 1:53 ` Teres Alexis, Alan Previn
2023-01-13 1:18 ` [Intel-gfx] [PATCH v5 3/6] mei: clean pending read with vtag on bus Alan Previn
2023-01-18 11:43 ` Winkler, Tomas
2023-01-13 1:18 ` [Intel-gfx] [PATCH v5 4/6] drm/i915/pxp: Invalidate all PXP fw sessions during teardown Alan Previn
2023-01-19 19:28 ` Rodrigo Vivi
2023-01-19 22:00 ` Teres Alexis, Alan Previn
2023-01-13 1:18 ` [Intel-gfx] [PATCH v5 5/6] drm/i915/pxp: Trigger the global teardown for before suspending Alan Previn
2023-01-19 19:35 ` Rodrigo Vivi
2023-01-19 22:31 ` Teres Alexis, Alan Previn
2023-01-13 1:18 ` [Intel-gfx] [PATCH v5 6/6] drm/i915/pxp: Pxp hw init should be in resume_complete Alan Previn
2023-01-19 19:10 ` Ceraolo Spurio, Daniele
2023-01-19 19:40 ` Rodrigo Vivi
2023-01-13 2:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/pxp: Add missing cleanup steps for PXP global-teardown Patchwork
2023-01-13 2:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f121bb857da18a50041328664397201587e66ddd.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=Vivi@freedesktop.org \
--cc=alexander.usyskin@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox