From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: Check for all subplatform bits
Date: Wed, 20 Jan 2021 08:13:34 +0000 [thread overview]
Message-ID: <f52e1e43-7dc9-e46b-06c5-2db17f73ab09@linux.intel.com> (raw)
In-Reply-To: <20210120012111.44184-2-umesh.nerlige.ramappa@intel.com>
On 20/01/2021 01:21, Umesh Nerlige Ramappa wrote:
> Current code is checking only 2 bits in the subplatform, but actually 3
> bits are allocated for the field. Check all 3 bits.
>
> Fixes: 805446c8347c9 (drm/i915: Introduce concept of a sub-platform)
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8376cff5ba86..38eca00c6f09 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1343,7 +1343,7 @@ intel_subplatform(const struct intel_runtime_info *info, enum intel_platform p)
> {
> const unsigned int pi = __platform_mask_index(info, p);
>
> - return info->platform_mask[pi] & INTEL_SUBPLATFORM_BITS;
> + return info->platform_mask[pi] & ((1 << INTEL_SUBPLATFORM_BITS) - 1);
> }
>
> static __always_inline bool
>
Yep. Luckily it affected only printout in the welcome message and error
capture metadata.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-20 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 1:21 [Intel-gfx] [PATCH 0/1] Fix subplatform check!! Umesh Nerlige Ramappa
2021-01-20 1:21 ` [Intel-gfx] [PATCH 1/1] drm/i915: Check for all subplatform bits Umesh Nerlige Ramappa
2021-01-20 8:13 ` Tvrtko Ursulin [this message]
2021-01-20 2:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Fix subplatform check!! Patchwork
2021-01-20 5:39 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52e1e43-7dc9-e46b-06c5-2db17f73ab09@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox