From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup overlay stolen memory leak
Date: Mon, 10 Dec 2012 23:50:44 +0000 [thread overview]
Message-ID: <f5ae8a$7pvcgt@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1355180865-3455-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 11 Dec 2012 00:07:45 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> We need to clean up the overlay first, before taking down the
> stolen memory allocator.
>
> This regression has been introducec in
>
> commit 8040513870399f1cb032cb8bc805df5042fedcdf
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Thu Nov 15 11:32:29 2012 +0000
>
> drm/i915: Allocate overlay registers from stolen memory
Time for a philosophical debate; I suggest the bug was latent and that
the cleanup order was wrong originally. Here, we probably want to
cleanup the overlay earlier, before we start tidying up the [pp]gtt etc.
Also you want to move the drm_mm_takedown() into
i915_gem_cleanup_stolen() for symmetry.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-10 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 23:07 [PATCH] drm/i915: fixup overlay stolen memory leak Daniel Vetter
2012-12-10 23:50 ` Chris Wilson [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-18 14:24 Daniel Vetter
2012-12-18 14:48 ` Chris Wilson
2012-12-18 15:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f5ae8a$7pvcgt@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox