From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>,
"Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Cc: intel-gfx@lists.freedesktop.org, andrzej.hajda@intel.com,
chris.p.wilson@intel.com, Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update doc for __intel_wakeref_put()
Date: Thu, 5 Jan 2023 20:48:46 +0100 [thread overview]
Message-ID: <f798c4e7-616c-bfef-dfcc-7c5902f35eba@linux.intel.com> (raw)
In-Reply-To: <Y7cNSlsSmEGbuZaK@ashyti-mobl2.lan>
Hi Andi and Ashutosh,
On 1/5/2023 6:47 PM, Andi Shyti wrote:
<snip>
>>> *
>>> - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref
>>> - * is retained and an error reported.
>>> + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the
>>> + * runtime-pm wakeref is retained.
>> @fn is used in multiple places in this file (including some 'get' usages)
>> so maybe needs to be fixed there too. Maybe better to just say somewhere
>> @fn refers to ops->get()/put() where applicable?
> yeah... as Nirmoy is at it, I think he can take care of the rest,
> would you, Nirmoy?
Sorry I missed that. I will squash everything into one patch.
Thanks,
Nirmoy
prev parent reply other threads:[~2023-01-05 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 15:38 [Intel-gfx] [PATCH] drm/i915: Update doc for __intel_wakeref_put() Nirmoy Das
2023-01-05 16:29 ` Dixit, Ashutosh
2023-01-05 17:47 ` Andi Shyti
2023-01-05 19:48 ` Das, Nirmoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f798c4e7-616c-bfef-dfcc-7c5902f35eba@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox