From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Pallavi Mishra <pallavi.mishra@intel.com>,
andi.shyti@intel.com, Andrzej Hajda <andrzej.hajda@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Drop FLAT CCS check
Date: Mon, 8 May 2023 10:07:06 +0200 [thread overview]
Message-ID: <f7f80c17-5f6b-d6fc-ac52-24d9bd58478a@linux.intel.com> (raw)
In-Reply-To: <20230505144005.23480-1-nirmoy.das@intel.com>
Pushed the series to drm-intel-gt-next.
This should handle few long standing MTL failures.
On 5/5/2023 4:40 PM, Nirmoy Das wrote:
> From: Pallavi Mishra <pallavi.mishra@intel.com>
>
> Remove FLAT CCS check from XY_FAST_COLOR_BLT usage, thus
> enabling MTL to use it.
>
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 3f638f198796..e0998879a0e1 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -920,7 +920,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
>
> GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12)
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50))
> ring_sz = XY_FAST_COLOR_BLT_DW;
> else if (ver >= 8)
> ring_sz = 8;
> @@ -931,7 +931,7 @@ static int emit_clear(struct i915_request *rq, u32 offset, int size,
> if (IS_ERR(cs))
> return PTR_ERR(cs);
>
> - if (HAS_FLAT_CCS(i915) && ver >= 12) {
> + if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
> *cs++ = XY_FAST_COLOR_BLT_CMD | XY_FAST_COLOR_BLT_DEPTH_32 |
> (XY_FAST_COLOR_BLT_DW - 2);
> *cs++ = FIELD_PREP(XY_FAST_COLOR_BLT_MOCS_MASK, mocs) |
prev parent reply other threads:[~2023-05-08 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 14:40 [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Drop FLAT CCS check Nirmoy Das
2023-05-05 14:40 ` [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add MTL for remapping CCS FBs Nirmoy Das
2023-05-05 20:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/mtl: Drop FLAT CCS check Patchwork
2023-05-05 21:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-06 10:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/mtl: Drop FLAT CCS check (rev2) Patchwork
2023-05-06 10:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-06 14:34 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/mtl: Drop FLAT CCS check Patchwork
2023-05-06 23:18 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/mtl: Drop FLAT CCS check (rev2) Patchwork
2023-05-08 8:07 ` Das, Nirmoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f80c17-5f6b-d6fc-ac52-24d9bd58478a@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=andi.shyti@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
--cc=pallavi.mishra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox