From: John Harrison <John.C.Harrison@Intel.com>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 07/11] trace.pl: Fix engine busy accounting in split mode
Date: Wed, 11 Jul 2018 23:38:54 -0700 [thread overview]
Message-ID: <f80a0fcd-e630-58cb-0fc6-79822791dfc6@Intel.com> (raw)
In-Reply-To: <20180709132004.14468-8-tvrtko.ursulin@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1123 bytes --]
On 7/9/2018 6:20 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> In split mode all requests have to be added up since they were previously
> re-arranged so there is no overlap.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: John Harrison <John.C.Harrison@intel.com>
> ---
> scripts/trace.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 60a8e441c1d9..52372e224da5 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -612,7 +612,8 @@ foreach my $key (@sorted_keys) {
> $db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
> $db{$key}->{'duration'} = $notify - $start;
>
> - $running{$ring} += $end - $start unless exists $db{$key}->{'no-end'};
> + $running{$ring} += $end - $start if $correct_durations or
> + not exists $db{$key}->{'no-end'};
> $runnable{$ring} += $db{$key}->{'execute-delay'};
> $queued{$ring} += $start - $db{$key}->{'execute-delay'} - $db{$key}->{'queue'};
>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
[-- Attachment #1.2: Type: text/html, Size: 1765 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-12 6:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 13:19 [PATCH i-g-t 00/11] trace.pl fixes and improvements Tvrtko Ursulin
2018-07-09 13:19 ` [PATCH i-g-t 01/11] trace.pl: Fix no context colouring mode Tvrtko Ursulin
2018-07-11 17:49 ` John Harrison
2018-07-09 13:19 ` [PATCH i-g-t 02/11] trace.pl: Improve readability of graphical timeline representation Tvrtko Ursulin
2018-07-11 22:07 ` John Harrison
2018-07-09 13:19 ` [PATCH i-g-t 03/11] trace.pl: Scale timeline for better precision Tvrtko Ursulin
2018-07-09 13:26 ` [igt-dev] " Chris Wilson
2018-07-09 13:40 ` Tvrtko Ursulin
2018-07-11 17:52 ` John Harrison
2018-07-09 13:19 ` [PATCH i-g-t 04/11] trace.pl: Put single context at single vertical slot Tvrtko Ursulin
2018-07-11 17:55 ` John Harrison
2018-07-09 13:19 ` [PATCH i-g-t 05/11] trace.pl: Fix HTML timestamp generation Tvrtko Ursulin
2018-07-11 18:01 ` John Harrison
2018-07-09 13:19 ` [PATCH i-g-t 06/11] trace.pl: Improve context colouring for large context id's Tvrtko Ursulin
2018-07-11 22:16 ` John Harrison
2018-07-09 13:20 ` [PATCH i-g-t 07/11] trace.pl: Fix engine busy accounting in split mode Tvrtko Ursulin
2018-07-12 6:38 ` John Harrison [this message]
2018-07-09 13:20 ` [PATCH i-g-t 08/11] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-07-09 13:20 ` [PATCH i-g-t 09/11] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-07-09 13:20 ` [PATCH i-g-t 10/11] trace.pl: Basic preemption support Tvrtko Ursulin
2018-07-09 13:20 ` [PATCH i-g-t 11/11] trace.pl: Fix request split mode Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80a0fcd-e630-58cb-0fc6-79822791dfc6@Intel.com \
--to=john.c.harrison@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox