Re: [PATCH] drm/i915: use BLT ring for flips on IVB

[Chris Wilson <chris@chris-wilson.co.uk>]

On Tue, 14 Jun 2011 00:14:11 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> On 06/09/2011 12:14 PM, Jesse Barnes wrote:
> > Found a couple more problems:
> >    1) MI_DISPLAY_FLIP should take a '1' in the last byte to indicate
> >       length on IVB
> >    2) apprently only the BLT ring version of the command actually causes
> >       interrupts to be generated
> >
> > With this patch, modetest -v works on my test platform.  Clearly it's in
> > need of more splitting though.  The case statement should be split into
> > per-chipset flip command generation.
> >
> > Signed-off-by: Jesse Barnes<jbarnes@virtuousgeek.org>
> 
> Reviewed-and-tested-by: Kenneth Graunke <kenneth@whitecape.org>

But it's not the neatest patch in the world ;-)

Using struct intel_ring_buffer *ring for all generation and switching
between blt/render on demand should be neater. Also we should be able
to do pageflips from either the render or blt ring on gen7, right? That
will be useful to avoid a synchronisation point.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre