From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: No need to poll FEC Enable Live bit
Date: Thu, 3 Dec 2020 20:32:23 +0530 [thread overview]
Message-ID: <f8104c01-aae0-d299-b18e-09ea6ebc433d@intel.com> (raw)
In-Reply-To: <20201125072634.27664-1-manasi.d.navare@intel.com>
On 11/25/2020 12:56 PM, Manasi Navare wrote:
> The Bspec does not mention polling the FEC Enable
> Live status bit. That is only there for debug purposes.
> So remove the polling from driver.
>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 92940a0c5ef8..6b3edd7e4423 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3507,12 +3507,6 @@ static void intel_ddi_enable_fec(struct intel_encoder *encoder,
> val = intel_de_read(dev_priv, dp_tp_ctl_reg(encoder, crtc_state));
> val |= DP_TP_CTL_FEC_ENABLE;
> intel_de_write(dev_priv, dp_tp_ctl_reg(encoder, crtc_state), val);
> -
> - if (intel_de_wait_for_set(dev_priv,
> - dp_tp_status_reg(encoder, crtc_state),
> - DP_TP_STATUS_FEC_ENABLE_LIVE, 1))
> - drm_err(&dev_priv->drm,
> - "Timed out waiting for FEC Enable Status\n");
> }
>
> static void intel_ddi_disable_fec_state(struct intel_encoder *encoder,
Looks good to me.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-12-03 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 7:26 [Intel-gfx] [PATCH] drm/i915/dp: No need to poll FEC Enable Live bit Manasi Navare
2020-11-25 8:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-25 10:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-03 15:02 ` Nautiyal, Ankit K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8104c01-aae0-d299-b18e-09ea6ebc433d@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox