Re: [PATCH 00/10] Preparatory patches for guardband optimization

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 10/16/2025 11:24 AM, Ankit Nautiyal wrote:
> Handle few cases which will need changes when guardband will no longer
> be matched to vblank length.
> - Fix the vblank_start evaluation.
> - Fix PSR wake latency checks wrt to guradband.
>
> Rev 2: PSR went through some changes recently, rebase the patches on latest
> PSR changes.
>
> Rev 3: Address comments from Ville and Jouni:
> - Add a patch to move intel_dpll_crtc_compute_clock() early in the
>    function.
> - Merge patch to adjust vblank_start and the readout changes.
> - Fix agument to alpm_config_valid()
> - Add documentation for retionale behind PSR late-stage configuration.
>
> Rev 4:
> - Update pipe_mode->vblank_start and actually merge patch to adjust
>    vblank_start and readout changes.
>
> Rev 5:
> - Reset other psr flags based on features that are dropped.
>
> Rev 6:
> - Make the order of panel_replay/sel_update flags consistent in Patch#5
> - Add a patch to have separate function for
>    intel_psr_set_non_psr_pipes()
> - Split patch to introduce intel_psr_compute_config_late() from patch to
>    check final vblank. Move Wa_18037818876 and
>    intel_psr_set_non_psr_pipes() to intel_psr_compute_config_late().
>
> Rev 7:
> - Address comments from Jouni on Patch#8
>
> Rev8:
> - Update the return type for intel_dp_compute_config_late() in patch#7
> - Add comments about pipe_mode update in patch#9


Thanks for the reviews. Pushed to drm-intel-next.

Regards,

Ankit

>
> Ankit Nautiyal (10):
>    drm/i915/vrr: Use crtc_vsync_start/end for computing
>      vrr.vsync_start/end
>    drm/i915/display: Move intel_dpll_crtc_compute_clock early
>    drm/i915/vrr:
>      s/intel_vrr_compute_config_late/intel_vrr_compute_guardband
>    drm/i915/vblank: Add helper to get correct vblank length
>    drm/i915/psr: Consider SCL lines when validating vblank for wake
>      latency
>    drm/i915/psr: Introduce helper intel_psr_set_non_psr_pipes()
>    drm/i915/display: Introduce dp/psr_compute_config_late()
>    drm/i915/psr: Check if final vblank is sufficient for PSR features
>    drm/i915/display: Add vblank_start adjustment logic for always-on VRR
>      TG
>    drm/i915/display: Prepare for vblank_delay for LRR
>
>   drivers/gpu/drm/i915/display/intel_ddi.c     |   7 +
>   drivers/gpu/drm/i915/display/intel_display.c |  18 +-
>   drivers/gpu/drm/i915/display/intel_dp.c      |  11 +
>   drivers/gpu/drm/i915/display/intel_dp.h      |   3 +
>   drivers/gpu/drm/i915/display/intel_psr.c     | 244 +++++++++++++------
>   drivers/gpu/drm/i915/display/intel_psr.h     |   2 +
>   drivers/gpu/drm/i915/display/intel_vblank.c  |  10 +
>   drivers/gpu/drm/i915/display/intel_vblank.h  |   2 +
>   drivers/gpu/drm/i915/display/intel_vrr.c     |  33 ++-
>   drivers/gpu/drm/i915/display/intel_vrr.h     |   2 +-
>   drivers/gpu/drm/i915/display/skl_watermark.c |   3 +-
>   11 files changed, 246 insertions(+), 89 deletions(-)
>