From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "andi.shyti@linux.intel.com" <andi.shyti@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"chris.p.wilson@linux.intel.com" <chris.p.wilson@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix typo in intel_frontbuffer
Date: Thu, 11 May 2023 05:17:03 +0000 [thread overview]
Message-ID: <fc80ae518f69a9feed38763efbf41e2aee61764e.camel@intel.com> (raw)
In-Reply-To: <ZFtffzlkDWujpMoH@ashyti-mobl2.lan>
On Wed, 2023-05-10 at 11:10 +0200, Andi Shyti wrote:
> Hi Jouni,
Hi Andi, thank you for checking my patch.
>
> On Wed, May 10, 2023 at 11:50:43AM +0300, Jouni Högander wrote:
> > Fix obvious typo in intel_frontbuffer forward declaration.
> >
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > index 830c11431ee8..cb362b09bf21 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > @@ -18,7 +18,7 @@
> > #include "i915_vma_resource.h"
> >
> > struct drm_i915_gem_object;
> > -struct intel_fronbuffer;
> > +struct intel_frontbuffer;
>
> Then I guess this is not necessary.
Removing it is also possible. I was thinking as i915_gem_object
contains intel_frontbuffer pointer keeping it would be more correct:
struct drm_i915_gem_object {
...
struct intel_frontbuffer __rcu *frontbuffer;
...
}
> Andi
>
> > struct intel_memory_region;
> >
> > /*
> > --
> > 2.34.1
BR,
Jouni Högander
next prev parent reply other threads:[~2023-05-11 5:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 8:50 [Intel-gfx] [PATCH] drm/i915: Fix typo in intel_frontbuffer Jouni Högander
2023-05-10 9:10 ` Andi Shyti
2023-05-11 5:17 ` Hogander, Jouni [this message]
2023-05-10 10:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-05-10 10:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-10 12:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc80ae518f69a9feed38763efbf41e2aee61764e.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox