From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ben@bwidawsk.net
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: don't use stolen space on VLV
Date: Wed, 01 May 2013 18:28:15 -0700 [thread overview]
Message-ID: <imfcgby3trqwqsddgimaicj8.1367458095303@email.android.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1183 bytes --]
Yes, without your badassness this would have taken me much longer to debug (especially since I was sure I had already tried avoiding stolen).
But I have a better patch to replace this that just makes a preallocated object from the BIOS gunk and lets us use the rest. Seems to be working here, so I'll clean it up and send it tomorrow. Just don't ask about the BIOS gunk; I can't talk about it.
--
Jesse Barnes, Intel Open Source Technology Center
-------- Original message --------
From: Ben Widawsky <ben@bwidawsk.net>
Date: 05/01/2013 6:00 PM (GMT-08:00)
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: don't use stolen space on VLV
On Wed, May 01, 2013 at 04:09:20PM -0700, Jesse Barnes wrote:
> BIOS stuffs things here we can't clobber.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuosugeek.org>
As I said in private email, I think the quirk is a bit better suited in
i915_stolen_to_physical(), and the commit message *could* explain things
a bit clearer, oh, and you're welcome.
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
--
Ben Widawsky, Intel Open Source Technology Center
[-- Attachment #1.2: Type: text/html, Size: 1467 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2013-05-02 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 1:28 Jesse Barnes [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-01 23:09 [PATCH 1/3] drm/i915: don't use stolen space on VLV Jesse Barnes
2013-05-02 1:00 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=imfcgby3trqwqsddgimaicj8.1367458095303@email.android.com \
--to=jbarnes@virtuousgeek.org \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox