Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: alsa-devel@alsa-project.org, Greg KH <gregkh@linuxfoundation.org>,
	intel-gfx@lists.freedesktop.org,
	Wang Xingchao <xingchao.wang@intel.com>,
	yakui.zhao@intel.com, stable@vger.kernel.org,
	michael.fu@intel.com, fengguang.wu@intel.com,
	Wang Xingchao <wangxingchao2011@gmail.com>
Subject: Re: [PATCH v2] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally
Date: Thu, 13 Sep 2012 16:31:05 +0200	[thread overview]
Message-ID: <s5h392myoye.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAKMK7uFBSAFXoLiE43r5AXYdbk2x5vdfFgD-4YP2RFi_axyoHw@mail.gmail.com>

At Thu, 13 Sep 2012 16:18:08 +0200,
Daniel Vetter wrote:
> 
> On Thu, Sep 13, 2012 at 4:00 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > But, this makes me wonder why this patch can't go into 3.6.  It's a
> > clear bug and the fix is trivial.
> >
> > Daniel, isn't it better to pick the fix (for 3.6) to drm-intel-fixes,
> > then merge back to drm-intel-next?
> 
> Well, on a quick read-through it didn't sound serious (just a bit of
> noise in dmesg and a few spurious reconfigs),

For the graphics side, yes.  But for the sound driver side, you'll
miss the jack-detection unplug event without this fix.

> and we're rather late in
> the -rc cycle.

Yes, but a bug is a bug is a bug :)
And the fix is two-liners.  If there were no conflict, would you mind
it?  I don't think so.

> Applying this on top of -fixes will cause a conflict, so didn't looked
> like I should bother.

Yeah, that's bad.

> Also, I _want_ the patch for -next so that git
> blame shows the commit and not some random conflicting merge.

With parallel development, you can't always get straight lines, as you
know well...


Takashi

  reply	other threads:[~2012-09-13 14:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  3:19 [PATCH v2] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally Wang Xingchao
2012-09-13  6:51 ` Takashi Iwai
2012-09-13 13:53   ` Wang Xingchao
2012-09-13 14:00     ` Takashi Iwai
2012-09-13 14:18       ` [alsa-devel] " Daniel Vetter
2012-09-13 14:31         ` Takashi Iwai [this message]
2012-09-17  7:58   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h392myoye.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michael.fu@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=wangxingchao2011@gmail.com \
    --cc=xingchao.wang@intel.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox