From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org,
Mengdong Lin <mengdong.lin@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
David Henningsson <david.henningsson@canonical.com>
Subject: Re: [PATCH 4/7] ALSA: hda - Split ELD update code from hdmi_present_sense()
Date: Mon, 30 Nov 2015 17:03:22 +0100 [thread overview]
Message-ID: <s5hegf7qxth.wl-tiwai@suse.de> (raw)
In-Reply-To: <20151130160033.GH3901@localhost>
On Mon, 30 Nov 2015 17:00:33 +0100,
Vinod Koul wrote:
>
> On Mon, Nov 30, 2015 at 02:37:48PM +0100, Takashi Iwai wrote:
> >
> > +/* update per_pin ELD from the given new ELD;
> > + * setup info frame and notification accordingly
> > + */
>
> nitpick, comment style
There is no preference in sound/* about this, and I myself prefer
without the extra line :)
Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-30 16:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 13:37 [PATCH 0/7] Add get_eld audio component for i915/HD-audio Takashi Iwai
2015-11-30 13:37 ` [PATCH 1/7] drm/i915: Remove superfluous NULL check Takashi Iwai
2015-11-30 13:37 ` [PATCH 2/7] drm/i915: Add get_eld audio component Takashi Iwai
2015-11-30 14:11 ` Daniel Vetter
2015-11-30 14:17 ` Daniel Vetter
2015-11-30 15:55 ` Takashi Iwai
2015-11-30 16:31 ` Daniel Vetter
2015-11-30 14:54 ` Takashi Iwai
2015-11-30 15:24 ` Ville Syrjälä
2015-11-30 15:29 ` Takashi Iwai
2015-11-30 15:34 ` David Henningsson
2015-11-30 15:45 ` Takashi Iwai
2015-11-30 16:09 ` Ville Syrjälä
2015-11-30 16:34 ` Daniel Vetter
2015-11-30 16:48 ` Ville Syrjälä
2015-11-30 16:53 ` Takashi Iwai
2015-11-30 13:37 ` [PATCH 3/7] drm/i915: refactoring audio component functions Takashi Iwai
2015-11-30 14:14 ` Daniel Vetter
2015-11-30 14:57 ` Takashi Iwai
2015-11-30 13:37 ` [PATCH 4/7] ALSA: hda - Split ELD update code from hdmi_present_sense() Takashi Iwai
2015-11-30 16:00 ` Vinod Koul
2015-11-30 16:03 ` Takashi Iwai [this message]
2015-11-30 13:37 ` [PATCH 5/7] ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling Takashi Iwai
2015-11-30 16:42 ` Vinod Koul
2015-11-30 16:44 ` Takashi Iwai
2015-11-30 13:37 ` [PATCH 6/7] ALSA: hda - Do zero-clear in snd_hdmi_parse_eld() itself Takashi Iwai
2015-11-30 13:37 ` [PATCH 7/7] ALSA: hda - Skip ELD notification during PM process Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hegf7qxth.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.vetter@intel.com \
--cc=david.henningsson@canonical.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mengdong.lin@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox