public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org,
	alsa-devel@alsa-project.org,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	jani.nikula@intel.com, Imre Deak <imre.deak@intel.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind
Date: Tue, 28 Sep 2021 12:22:33 +0200	[thread overview]
Message-ID: <s5hh7e5ngnq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210922085432.2776886-1-kai.vehmanen@linux.intel.com>

On Wed, 22 Sep 2021 10:54:32 +0200,
Kai Vehmanen wrote:
(snip)
> --- a/drivers/base/component.c
> +++ b/drivers/base/component.c
> @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master,
>  		return 0;
>  	}
>  
> -	if (!devres_open_group(master->parent, NULL, GFP_KERNEL))
> +	if (!devres_open_group(master->parent, master, GFP_KERNEL))
>  		return -ENOMEM;
>  
>  	/* Found all components */
> @@ -258,6 +258,7 @@ static int try_to_bring_up_master(struct master *master,
>  		return ret;
>  	}
>  
> +	devres_close_group(master->parent, NULL);

Just wondering whether we should pass master here instead of NULL,
too?


thanks,

Takashi

  parent reply	other threads:[~2021-09-28 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  8:54 [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind Kai Vehmanen
2021-09-22 10:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for component: do not leave master devres group open after bind (rev2) Patchwork
2021-09-22 12:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-28 10:22 ` Takashi Iwai [this message]
2021-09-28 10:45   ` [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind Kai Vehmanen
2021-10-05 14:35 ` Greg KH
2021-10-06 13:47   ` Kai Vehmanen
2021-10-13 13:09     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hh7e5ngnq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox