Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH 11/11] ALSA: x86: Register multiple PCM devices for the LPE audio card
Date: Wed, 26 Apr 2017 09:19:21 +0200	[thread overview]
Message-ID: <s5hr30ffxfq.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5hvaprfy41.wl-tiwai@suse.de>

On Wed, 26 Apr 2017 09:04:46 +0200,
Takashi Iwai wrote:
> 
> On Wed, 26 Apr 2017 03:58:57 +0200,
> Pierre-Louis Bossart wrote:
> > 
> > On 04/25/2017 03:27 PM, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Now that everything is in place let's register a PCM device for
> > > each pipe of the display engine. This will make it possible to
> > > actually output audio to multiple displays at the same time. And
> > > it avoids modesets on unrelated displays from clobbering up the
> > > ELD and whatnot for the display currently doing the playback.
> > >
> > > The alternative would be to have a PCM device per port, but per-pipe
> > > is easier since the hardware actually works that way.
> > Very nice. I just tested on a CHT Zotac box which has two connectors
> > (1 HDMI and 1 DP), and I get sound concurrently on both, with hdmi
> > being listed as device 2 and DP as device 0.
> > I thought there were hardware restrictions but you proved me wrong. Kudos.
> > 
> > The only point that I find weird is that the jacks are reported as
> > 'on' on the 3 pipes, is there a way to tie them to an actual cable
> > being used?
> 
> The pdata check was changed to check port=-1 as the monitor off in the
> patch 6.  Maybe the initialization is missing?

I guess the problem is that the hotplug wq is called at the
initialization to retrieve the pdata for all pipes.  It's called with
uninitialized port=0, so all flags are on at init.

And it implies the potential problem: the pdata contains the
information only for a single pipe.  Maybe it should keep the
status/ELD for all three pipes.


Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-04-26  7:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:27 [PATCH 00/11] drm/i915: LPE audio runtime PM and multipipe ville.syrjala
2017-04-25 20:27 ` [PATCH 01/11] drm/i915: Fix runtime PM for LPE audio ville.syrjala
2017-04-25 20:27 ` [PATCH 02/11] ALSA: x86: Clear the pdata.notify_lpe_audio pointer before teardown ville.syrjala
2017-04-25 20:27 ` [PATCH 03/11] drm/i915: Stop pretending to mask/unmask LPE audio interrupts ville.syrjala
2017-04-26  0:27   ` Pierre-Louis Bossart
2017-04-26 13:27     ` Ville Syrjälä
2017-04-25 20:27 ` [PATCH 04/11] drm/i915: Remove the unsued pending_notify from LPE platform data ville.syrjala
2017-04-25 20:27 ` [PATCH 05/11] drm/i915: Replace tmds_clock_speed and link_rate with just ls_clock ville.syrjala
2017-04-26  1:09   ` [alsa-devel] " Pierre-Louis Bossart
2017-04-26 13:28     ` Ville Syrjälä
2017-04-25 20:27 ` [PATCH 06/11] drm/i915: Remove hdmi_connected from LPE audio pdata ville.syrjala
2017-04-25 20:27 ` [PATCH 07/11] drm/i915: Reorganize intel_lpe_audio_notify() arguments ville.syrjala
2017-04-25 20:27 ` [PATCH 08/11] drm/i915: Clean up the LPE audio platform data ville.syrjala
2017-04-25 20:27 ` [PATCH 09/11] ALSA: x86: Prepare LPE audio ctls for multiple PCMs ville.syrjala
2017-04-25 20:27 ` [PATCH 10/11] ALSA: x86: Split snd_intelhad into card and PCM specific structures ville.syrjala
2017-04-25 20:27 ` [PATCH 11/11] ALSA: x86: Register multiple PCM devices for the LPE audio card ville.syrjala
2017-04-26  1:58   ` Pierre-Louis Bossart
2017-04-26  7:04     ` [alsa-devel] " Takashi Iwai
2017-04-26  7:19       ` Takashi Iwai [this message]
2017-04-26 13:49         ` Ville Syrjälä
2017-04-26 14:04           ` Takashi Iwai
2017-04-25 20:46 ` ✓ Fi.CI.BAT: success for drm/i915: LPE audio runtime PM and multipipe Patchwork
2017-04-26  7:29 ` [PATCH 00/11] " Takashi Iwai
2017-04-26 13:38   ` Ville Syrjälä
2017-04-26 13:47     ` Takashi Iwai
2017-04-26 13:56       ` Ville Syrjälä
2017-04-26 19:59       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr30ffxfq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox