From: Takashi Iwai <tiwai@suse.de>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
jeeja.kp@intel.com, libin.yang@linux.intel.com
Subject: Re: [PATCH v3] drm/i915/dp: DP audio API changes for MST
Date: Thu, 11 Aug 2016 09:23:17 +0200 [thread overview]
Message-ID: <s5hshubg462.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160811062631.GW4329@intel.com>
On Thu, 11 Aug 2016 08:26:31 +0200,
Ville Syrjälä wrote:
>
> > --- a/sound/hda/hdac_i915.c
> > +++ b/sound/hda/hdac_i915.c
> > @@ -201,7 +201,8 @@ static int pin2port(struct hdac_device *codec, hda_nid_t pin_nid)
> > * This function sets N/CTS value based on the given sample rate.
> > * Returns zero for success, or a negative error code.
> > */
> > -int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid, int rate)
> > +int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid,
> > + int pipe, int rate)
>
> I thought you'd still want to call it 'dev_id' on the hda side, and just
> do the dev_id->pipe conversion here next to the pin->port conversion?
> Just figured that would be less confusing for people who are just familiar
> with hda and not i915.
Agreed, it's more consistent to have a pair of the same terms
(pipe, port) vs (dev_id, nid).
Except for that, the changes in the audio side look trivial, and it's
probably better to go through drm tree, so feel free to take my ack:
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-11 7:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 20:58 [PATCH v2] drm/i915/dp: DP audio API changes for MST Dhinakaran Pandiyan
2016-08-10 10:38 ` ✗ Ro.CI.BAT: failure for drm/i915/dp: DP audio API changes for MST (rev2) Patchwork
2016-08-10 14:21 ` [PATCH v2] drm/i915/dp: DP audio API changes for MST Ville Syrjälä
2016-08-10 19:33 ` Pandiyan, Dhinakaran
2016-08-10 19:41 ` [PATCH v3] " Dhinakaran Pandiyan
2016-08-11 6:26 ` Ville Syrjälä
2016-08-11 7:10 ` Pandiyan, Dhinakaran
2016-08-11 7:39 ` Ville Syrjälä
2016-08-12 4:28 ` Pandiyan, Dhinakaran
2016-08-12 5:18 ` Ville Syrjälä
2016-08-13 0:16 ` Pandiyan, Dhinakaran
2016-08-13 0:50 ` Pandiyan, Dhinakaran
2016-08-11 7:23 ` Takashi Iwai [this message]
2016-08-11 5:33 ` ✗ Ro.CI.BAT: failure for drm/i915/dp: DP audio API changes for MST (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hshubg462.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jeeja.kp@intel.com \
--cc=libin.yang@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox