From: Takashi Iwai <tiwai@suse.de>
To: Jani Nikula <jani.nikula@intel.com>
Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com,
daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
han.lu@linux.intel.com, han.lu@intel.com,
libin.yang@linux.intel.com
Subject: Re: [PATCH 1/1] drm/i915/audio: apply SKL codec wake up patch to BXT
Date: Thu, 19 Nov 2015 11:29:01 +0100 [thread overview]
Message-ID: <s5htwoib7v6.wl-tiwai@suse.de> (raw)
In-Reply-To: <877flecq4y.fsf@intel.com>
On Thu, 19 Nov 2015 10:09:01 +0100,
Jani Nikula wrote:
>
> On Thu, 19 Nov 2015, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Thu, 19 Nov 2015, han.lu@intel.com wrote:
> >> From: "Lu, Han" <han.lu@intel.com>
> >>
> >> Signed-off-by: Lu, Han <han.lu@intel.com>
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> >> index 63d4706..8310bf3 100644
> >> --- a/drivers/gpu/drm/i915/intel_audio.c
> >> +++ b/drivers/gpu/drm/i915/intel_audio.c
> >> @@ -591,7 +591,8 @@ static void i915_audio_component_codec_wake_override(struct device *dev,
> >> struct drm_i915_private *dev_priv = dev_to_i915(dev);
> >> u32 tmp;
> >>
> >> - if (!IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv))
> >> + if (!IS_SKYLAKE(dev_priv) && !IS_BROXTON(dev_priv) &&
> >> + !IS_KABYLAKE(dev_priv))
> >
> > How about if (INTEL_INFO(dev_priv)->gen < 9)?
>
> Oh, and I guess we also wonder why this is only relevant for the latest
> platforms?
My understanding is that it's a workaround specific to HSW/BDW.
It's issued only during the audio controller initialization and at the
resume. But I never know why it's needed, it's a black magic :)
Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-19 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 8:48 [PATCH 1/1] drm/i915/audio: apply SKL codec wake up patch to BXT han.lu
2015-11-19 9:08 ` Jani Nikula
2015-11-19 9:09 ` Jani Nikula
2015-11-19 10:29 ` Takashi Iwai [this message]
2015-11-19 14:28 ` Lu, Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htwoib7v6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.vetter@ffwll.ch \
--cc=han.lu@intel.com \
--cc=han.lu@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=libin.yang@linux.intel.com \
--cc=mengdong.lin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox