From: sashiko-bot@kernel.org
To: ElXreno <elxreno@gmail.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm/i915/panel: Fix the pixel clock overflow in the VRR vtotal
Date: Sat, 14 Nov 2026 01:54:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-214017@kernel.org> (raw)
In-Reply-To: <20261114014335.2132756-2-elxreno@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/i915/panel: commit Signed-off-by trailer uses handle
instead of real name
--
commit a81f42546a1b676a6932361ec102d9c524823aa2
Author: ElXreno <elxreno@gmail.com>
> drm/i915/panel: Fix the pixel clock overflow in the VRR vtotal
>
> intel_panel_compute_config_vrr() multiplies the pixel clock in kHz by
> 1000 in a signed int. A 3840x2400@240 timing has a 2342.4 MHz pixel
> clock, the product overflows, and the vertical total computed for a
> refresh rate other than that of the fixed mode comes out negative.
>
> Do the multiplication in 64 bits.
>
> This needs a fixed mode above 2147 MHz, so one that uses the joiner,
> inside the VRR range of the panel, and a request for another refresh
> rate that ends up on that fixed mode, as the allow_modeset=false path
> does for a mode that is VRR compatible with the current one.
>
> Fixes: a2da67028cd0 ("drm/i915: Allow arbitrary refresh rates with VRR eDP panels")
> Signed-off-by: ElXreno <elxreno@gmail.com>
[Severity: High]
Both the Author header and the Signed-off-by trailer use the single-word
handle ElXreno rather than a real full name. Documentation/process/submitting-patches.rst
requires contributors to sign off using a known real identity under the
Developer's Certificate of Origin rather than a pseudonym or handle.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114014335.2132756-1-elxreno@gmail.com?part=1
next prev parent reply other threads:[~2026-11-14 1:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261114014335.2132756-1-elxreno@gmail.com>
[not found] ` <20261114014335.2132756-5-elxreno@gmail.com>
2026-11-14 1:48 ` [PATCH 4/7] drm/i915: Split intel_update_crtc() into its stages sashiko-bot
[not found] ` <20261114014335.2132756-3-elxreno@gmail.com>
2026-11-14 1:52 ` [PATCH 2/7] drm/i915/vrr: Fix the pixel clock overflow in the vmax computation sashiko-bot
[not found] ` <20261114014335.2132756-7-elxreno@gmail.com>
2026-11-14 1:53 ` [PATCH 6/7] drm/i915: Evade the vblank on the scanline of the joiner primary sashiko-bot
[not found] ` <20261114014335.2132756-2-elxreno@gmail.com>
2026-11-14 1:54 ` sashiko-bot [this message]
[not found] ` <20261114014335.2132756-4-elxreno@gmail.com>
2026-11-14 1:56 ` [PATCH 3/7] drm/i915/vrr: Leave the transcoder to " sashiko-bot
[not found] ` <20261114014335.2132756-6-elxreno@gmail.com>
2026-11-14 2:02 ` [PATCH 5/7] drm/i915: Arm joined pipes within one vblank evasion for VRR sashiko-bot
[not found] ` <20261114014335.2132756-8-elxreno@gmail.com>
2026-11-14 2:24 ` [PATCH 7/7] drm/i915/vrr: Allow VRR with the pipe joiner sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214017@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=elxreno@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox