From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: apply phase pointer override on SNB+ too
Date: Fri, 29 Jul 2011 10:28:51 -0700 [thread overview]
Message-ID: <yun39hphu7g.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1311898032-6625-1-git-send-email-jbarnes@virtuousgeek.org>
[-- Attachment #1.1: Type: text/plain, Size: 838 bytes --]
On Thu, 28 Jul 2011 17:07:12 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> +#define _TRANSA_CHICKEN2 0xf0064
> +#define _TRANSB_CHICKEN2 0xf1064
> +#define TRANS_CHICKEN2(pipe) _PIPE(pipe, _TRANSA_CHICKEN2, _TRANSB_CHICKEN2)
> +#define TRANS_AUTOTRAIN_GEN_STALL_DIS (1<<31)
> +
> +#define SOUTH_CHICKEN1 0xc2000
> +#define FDIA_PHASE_SYNC_SHIFT 18
> +#define FDI_PHASE_SYNC_OVR_EN (3)
How about
#define FDIA_PHASE_SYNC_OVERRIDE_SHIFT 19
#define FDIA_PHASE_SYNC_ENABLE_SHIFT 18
#define FDI_PHASE_SYNC_OVERRIDE(pipe) (1 << (FDIA_PHASE_SYNC_OVERRIDE_SHIFT - (pipe) * 2))
#define FDI_PHASE_SYNC_ENABLE(pipe) (1 << (FDIA_PHASE_SYNC_ENABLE_SHIFT - (pipe) * 2))
defines instead?
Then use FDI_PHASE_SYNC_OVERRIDE(pipe) | FDI_PHASE_SYNC_ENABLE(pipe)
in the code.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-29 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 0:07 [PATCH] drm/i915: apply phase pointer override on SNB+ too Jesse Barnes
2011-07-29 17:28 ` Keith Packard [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-29 19:42 Jesse Barnes
2011-07-29 21:22 ` Keith Packard
2011-07-29 21:55 ` Jesse Barnes
2011-07-29 17:50 Jesse Barnes
2011-07-29 18:47 ` Keith Packard
2011-07-29 19:43 ` Jesse Barnes
2011-07-29 0:06 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yun39hphu7g.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox