Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Clear any errors recorded before i915.ko is loaded
Date: Tue, 05 Apr 2011 18:27:45 -0700	[thread overview]
Message-ID: <yunaag4mani.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1302040846-18447-1-git-send-email-chris@chris-wilson.co.uk>


[-- Attachment #1.1: Type: text/plain, Size: 696 bytes --]

On Tue,  5 Apr 2011 23:00:46 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> This looks like it fixes two bugs:
> 
> 1) What if there is an error recorded before we start and so we
> immediately service an IIR/EIR upon intalling the IRQ. Did we generate
> that error during initialisation or was that SEP? Now we do stuff before
> we even install the IRQ so there is a possibility that we zap one of our
> own.

How will processing a pre-existing error condition cause trouble?

> Does EIR even persist between phases to cause these issues in the
> first place?

Yeah, seems like a bit of testing might be able to check this fairly quickly.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-04-06  1:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 22:00 [PATCH] drm/i915: Clear any errors recorded before i915.ko is loaded Chris Wilson
2011-04-06  1:27 ` Keith Packard [this message]
2011-04-06  6:52   ` Chris Wilson
2011-04-07  3:55     ` Keith Packard
2011-05-04 19:21 ` Keith Packard
2011-05-04 19:32   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunaag4mani.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox