From: Keith Packard <keithp@keithp.com>
To: "Feng, Boqun" <boqun.feng@intel.com>, intel-gfx@lists.freedesktop.org
Cc: stable@kernel.org
Subject: Re: [PATCH] drm/i915: fix user irq miss in BSD ring on g4x
Date: Fri, 13 May 2011 08:07:57 -0700 [thread overview]
Message-ID: <yunei427i5u.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1304397744-29312-1-git-send-email-boqun.feng@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1034 bytes --]
On Tue, 3 May 2011 12:42:24 +0800, "Feng, Boqun" <boqun.feng@intel.com> wrote:
> On g4x, user interrupt in BSD ring is missed.
> g4x and ironlake share the same bsd_ring, but their interrupt control
> interfaces are different. On g4x i915_enable_irq and i915_disable_irq
> are used to enable/disable irq,and user interrupt flag in BSD ring on
> g4x is I915_BSD_USER_INTERRUPT.
> The ring_get_irq and ring_put_irq use ironlake style interrupt control
> interface. So rather than use them, expand their code and add an if-else
> statement about the device version.
Please don't open-code ring_get_irq here. I'd suggest a cleaner fix
would be to either just conditionally call ring_get_irq, or to stick the
BSD interrupt value in dev_priv where you can get it:
if (IS_G4X(dev))
ring_get_irq(ring, I915_BSD_USER_INTERRUPT);
else
ring_get_irq(ring, GT_BSD_USER_INTERRUPT);
or
ring_get_irq(ring, dev_priv->bsd_user_interrupt);
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-05-13 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 4:42 [PATCH] drm/i915: fix user irq miss in BSD ring on g4x Feng, Boqun
2011-05-13 15:07 ` Keith Packard [this message]
2011-05-16 4:43 ` Feng, Boqun
2011-05-16 7:07 ` Keith Packard
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 8:02 Feng, Boqun
2011-05-16 10:27 ` Konstantin Belousov
2011-05-16 19:53 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunei427i5u.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=boqun.feng@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox