From: Keith Packard <keithp@keithp.com>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI
Date: Tue, 20 Sep 2011 12:43:31 -0700 [thread overview]
Message-ID: <yunvcsndmos.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1316539885-3196-1-git-send-email-simon.farnsworth@onelan.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]
On Tue, 20 Sep 2011 18:31:25 +0100, Simon Farnsworth <simon.farnsworth@onelan.co.uk> wrote:
> + /* Set up hotplug command - note paranoia about contents of reply.
> + * We simply clear out the bits we understand, and hope that
> + * the rest are in good shape for the hardware.
> + */
> + intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HOT_PLUG_SUPPORT,
> + &intel_sdvo->hotplug_active, 2);
> + intel_sdvo->hotplug_active[0] &= 0x3;
> +
This appears to unconditionally set the bits for devices 0 and 1, making
the dvi-specific code that sets the device bit irrelevant. I think you
just want to set hotplug_active to 0.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-09-20 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 17:31 [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI Simon Farnsworth
2011-09-20 19:43 ` Keith Packard [this message]
2011-09-21 9:08 ` Simon Farnsworth
2011-09-21 14:58 ` Keith Packard
2011-09-21 15:18 ` Simon Farnsworth
2011-09-21 15:47 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunvcsndmos.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=simon.farnsworth@onelan.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox