Re: [Intel-wired-lan] [PATCH net v2 0/2] Improvements for default VSI filter handling

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 7/1/2022 8:17 AM, Michal Wilczynski wrote:
> Currently when vf-true-promisc-support private flag is set to false, default VSI
> switch filter is used instead of a proper promiscuous one. Unfortunately flow for
> default VSI is a bit different, which leads to improper behavior like not being
> able to enable promisc mode on multiple VF's, or filter not being removed in
> 'trust off' flow.
> 
> v2:
> - Changed net-next to net, since this can be treated as a bug fixes

I think I may have been unclear on my previous question regarding this. 
Patch 1 looks like improvement for handling so net-next seems the right 
target for it. Patch 2 seems like it's resolving a bug which is why I 
was asking why that wasn't going to net.

Also, for future reference, if the patch is going to net, you need to 
add a Fixes: tag [1] to the patch(es).

[1] 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

> Michal Wilczynski (2):
>    ice: Introduce enabling promiscuous mode on multiple VF's
> v2:
> - Removed unnecessary parameter in function description
> - Removed unnecessary comments
> - Moved ice_vsi_uses_fltr function
> - Removed unnecessary blank lines
> - Changed commit message to utilize full 75 characters
> 
>    ice: Fix promiscuous mode not turning off
> 
>   drivers/net/ethernet/intel/ice/ice.h          |   2 -
>   drivers/net/ethernet/intel/ice/ice_eswitch.c  |   8 +-
>   drivers/net/ethernet/intel/ice/ice_ethtool.c  |   2 +-
>   drivers/net/ethernet/intel/ice/ice_lib.c      |  67 ++++-----
>   drivers/net/ethernet/intel/ice/ice_lib.h      |   9 +-
>   drivers/net/ethernet/intel/ice/ice_main.c     |  14 +-
>   drivers/net/ethernet/intel/ice/ice_switch.c   | 135 +++++++++---------
>   drivers/net/ethernet/intel/ice/ice_switch.h   |   6 +-
>   drivers/net/ethernet/intel/ice/ice_type.h     |   4 -
>   drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  89 +++++++++---
>   drivers/net/ethernet/intel/ice/ice_vf_lib.h   |   7 +-
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c |  51 +++----
>   12 files changed, 216 insertions(+), 178 deletions(-)
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan