Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Wilczynski, Michal" <michal.wilczynski@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net v2 0/2] Improvements for default VSI filter handling
Date: Tue, 12 Jul 2022 14:57:25 -0700	[thread overview]
Message-ID: <90677c77-f94a-72bc-b515-ea7b65f1ef00@intel.com> (raw)
In-Reply-To: <af311e64-7509-ba37-e288-32158ac13d60@intel.com>



On 7/4/2022 4:23 AM, Wilczynski, Michal wrote:
> On 7/1/2022 11:01 PM, Tony Nguyen wrote:
>>
>>
>> On 7/1/2022 8:17 AM, Michal Wilczynski wrote:
>>> Currently when vf-true-promisc-support private flag is set to false, 
>>> default VSI
>>> switch filter is used instead of a proper promiscuous one. 
>>> Unfortunately flow for
>>> default VSI is a bit different, which leads to improper behavior like 
>>> not being
>>> able to enable promisc mode on multiple VF's, or filter not being 
>>> removed in
>>> 'trust off' flow.
>>>
>>> v2:
>>> - Changed net-next to net, since this can be treated as a bug fixes
>>
>> I think I may have been unclear on my previous question regarding 
>> this. Patch 1 looks like improvement for handling so net-next seems 
>> the right target for it. Patch 2 seems like it's resolving a bug which 
>> is why I was asking why that wasn't going to net.
>>
>> Also, for future reference, if the patch is going to net, you need to 
>> add a Fixes: tag [1] to the patch(es).
>>
>> [1] 
>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes 
>>
> 
> 
> Hi, my understanding was that a patchset has to go either to net or 
> net-next, I would have to split this patch series to two patches, one 
> for net, one for net-next.

Yes, this is what I had in mind...

> But I'm not really willing to to that, cause 
> they are kind of close together and both of those patches actually fix 
> bugs.
> 
> I was under impression that those changes were a bit too much code 
> changes for net, that's why I chose net-next.

As a series, I agree, this is to large for net. If they have to go 
together, then net-next would be the better choice. I'll go ahead and 
apply this to next-queue then.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

      reply	other threads:[~2022-07-12 21:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 15:17 [Intel-wired-lan] [PATCH net v2 0/2] Improvements for default VSI filter handling Michal Wilczynski
2022-07-01 15:17 ` [Intel-wired-lan] [PATCH net v2 1/2] ice: Introduce enabling promiscuous mode on multiple VF's Michal Wilczynski
2022-07-01 15:17 ` [Intel-wired-lan] [PATCH net v2 2/2] ice: Fix promiscuous mode not turning off Michal Wilczynski
2022-07-01 21:01 ` [Intel-wired-lan] [PATCH net v2 0/2] Improvements for default VSI filter handling Tony Nguyen
2022-07-04 11:23   ` Wilczynski, Michal
2022-07-12 21:57     ` Tony Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90677c77-f94a-72bc-b515-ea7b65f1ef00@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=michal.wilczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox