Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
@ 2023-03-07 18:19 Bjorn Helgaas
  2023-03-07 18:19 ` [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: Ajit Khaparde, Chris Snook, Somnath Kotur, Tony Nguyen,
	Manish Chopra, Rahul Verma, Jesse Brandeburg, Yisen Zhuang,
	intel-wired-lan, Veerasenareddy Burru, Martin Habets,
	Mengyuan Lou, Abhijit Ayarekar, Shahed Shaikh, Ariel Elior,
	Jiawen Wu, Bjorn Helgaas, Michael Chan, Salil Mehta,
	GR-Linux-NIC-Dev, Sriharsha Basavapatna, Rasesh Mody, netdev,
	linux-kernel, Edward Cree, Raju Rangoju, Dimitris Michailidis,
	Sudarsana Kalluru

From: Bjorn Helgaas <bhelgaas@google.com>

Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
which appeared in v6.0, the PCI core has enabled PCIe error reporting for
all devices during enumeration.

Remove driver code to do this and remove unnecessary includes of
<linux/aer.h> from several other drivers.

Intel folks, sorry that I missed removing the <linux/aer.h> includes in the
first series.


Bjorn Helgaas (28):
  alx: Drop redundant pci_enable_pcie_error_reporting()
  be2net: Drop redundant pci_enable_pcie_error_reporting()
  bnx2: Drop redundant pci_enable_pcie_error_reporting()
  bnx2x: Drop redundant pci_enable_pcie_error_reporting()
  bnxt: Drop redundant pci_enable_pcie_error_reporting()
  cxgb4: Drop redundant pci_enable_pcie_error_reporting()
  net/fungible: Drop redundant pci_enable_pcie_error_reporting()
  net: hns3: remove unnecessary aer.h include
  netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
  octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
  qed: Drop redundant pci_enable_pcie_error_reporting()
  net: qede: Remove unnecessary aer.h include
  qlcnic: Drop redundant pci_enable_pcie_error_reporting()
  qlcnic: Remove unnecessary aer.h include
  sfc: Drop redundant pci_enable_pcie_error_reporting()
  sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
  sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
  sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
  net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
  net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
  e1000e: Remove unnecessary aer.h include
  fm10k: Remove unnecessary aer.h include
  i40e: Remove unnecessary aer.h include
  iavf: Remove unnecessary aer.h include
  ice: Remove unnecessary aer.h include
  igb: Remove unnecessary aer.h include
  igc: Remove unnecessary aer.h include
  ixgbe: Remove unnecessary aer.h include

 drivers/net/ethernet/atheros/alx/main.c       |  4 ----
 drivers/net/ethernet/broadcom/bnx2.c          | 21 -------------------
 drivers/net/ethernet/broadcom/bnx2.h          |  1 -
 drivers/net/ethernet/broadcom/bnx2x/bnx2x.h   |  1 -
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  | 19 -----------------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  4 ----
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  4 ----
 drivers/net/ethernet/emulex/benet/be_main.c   |  8 -------
 .../net/ethernet/fungible/funcore/fun_dev.c   |  5 -----
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |  1 -
 drivers/net/ethernet/intel/e1000e/netdev.c    |  1 -
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  |  1 -
 drivers/net/ethernet/intel/i40e/i40e.h        |  1 -
 drivers/net/ethernet/intel/iavf/iavf.h        |  1 -
 drivers/net/ethernet/intel/ice/ice.h          |  1 -
 drivers/net/ethernet/intel/igb/igb_main.c     |  1 -
 drivers/net/ethernet/intel/igc/igc_main.c     |  1 -
 drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 -
 .../ethernet/marvell/octeon_ep/octep_main.c   |  4 ----
 .../ethernet/qlogic/netxen/netxen_nic_main.c  | 10 +--------
 drivers/net/ethernet/qlogic/qed/qed_main.c    |  9 --------
 drivers/net/ethernet/qlogic/qede/qede_main.c  |  1 -
 .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c   |  1 -
 .../net/ethernet/qlogic/qlcnic/qlcnic_main.c  |  4 ----
 .../net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c |  1 -
 drivers/net/ethernet/sfc/ef100.c              |  3 ---
 drivers/net/ethernet/sfc/efx.c                |  5 -----
 drivers/net/ethernet/sfc/falcon/efx.c         |  9 --------
 drivers/net/ethernet/sfc/siena/efx.c          |  5 -----
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |  4 ----
 .../net/ethernet/wangxun/txgbe/txgbe_main.c   |  5 -----
 31 files changed, 1 insertion(+), 136 deletions(-)

-- 
2.25.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include
  2023-03-07 18:19 [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
@ 2023-03-07 18:19 ` Bjorn Helgaas
  2023-03-15 12:00   ` naamax.meir
  2023-03-07 19:28 ` [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Jesse Brandeburg
  2023-03-09  7:40 ` patchwork-bot+netdevbpf
  2 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2023-03-07 18:19 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Jesse Brandeburg, intel-wired-lan,
	Bjorn Helgaas, Tony Nguyen

From: Bjorn Helgaas <bhelgaas@google.com>

<linux/aer.h> is unused, so remove it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index e1eb1de88bf9..6f5c16aebcbf 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -23,7 +23,6 @@
 #include <linux/smp.h>
 #include <linux/pm_qos.h>
 #include <linux/pm_runtime.h>
-#include <linux/aer.h>
 #include <linux/prefetch.h>
 #include <linux/suspend.h>
 
-- 
2.25.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
  2023-03-07 18:19 [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
  2023-03-07 18:19 ` [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
@ 2023-03-07 19:28 ` Jesse Brandeburg
  2023-03-09  7:40 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 5+ messages in thread
From: Jesse Brandeburg @ 2023-03-07 19:28 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: Ajit Khaparde, Chris Snook, Somnath Kotur, Tony Nguyen,
	Manish Chopra, Rahul Verma, Yisen Zhuang, intel-wired-lan,
	Veerasenareddy Burru, Martin Habets, Mengyuan Lou,
	Abhijit Ayarekar, Shahed Shaikh, Ariel Elior, Jiawen Wu,
	Bjorn Helgaas, Michael Chan, Salil Mehta, GR-Linux-NIC-Dev,
	Sriharsha Basavapatna, Rasesh Mody, netdev, linux-kernel,
	Edward Cree, Raju Rangoju, Dimitris Michailidis,
	Sudarsana Kalluru

On 3/7/2023 10:19 AM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> which appeared in v6.0, the PCI core has enabled PCIe error reporting for
> all devices during enumeration.
> 
> Remove driver code to do this and remove unnecessary includes of
> <linux/aer.h> from several other drivers.
> 
> Intel folks, sorry that I missed removing the <linux/aer.h> includes in the
> first series.

For the Intel Drivers:
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>


_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable
  2023-03-07 18:19 [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
  2023-03-07 18:19 ` [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
  2023-03-07 19:28 ` [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Jesse Brandeburg
@ 2023-03-09  7:40 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-09  7:40 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: ajit.khaparde, chris.snook, GR-Linux-NIC-Dev, somnath.kotur,
	edumazet, anthony.l.nguyen, manishc, rahulv, jesse.brandeburg,
	yisen.zhuang, intel-wired-lan, vburru, habetsm.xilinx, pabeni,
	aayarekar, shshaikh, aelior, jiawenwu, kuba, bhelgaas,
	michael.chan, salil.mehta, mengyuanlou, sriharsha.basavapatna,
	rmody, netdev, linux-kernel, skalluru, ecree.xilinx, rajur,
	dmichail, davem

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  7 Mar 2023 12:19:11 -0600 you wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"),
> which appeared in v6.0, the PCI core has enabled PCIe error reporting for
> all devices during enumeration.
> 
> Remove driver code to do this and remove unnecessary includes of
> <linux/aer.h> from several other drivers.
> 
> [...]

Here is the summary with links:
  - [01/28] alx: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1de2a84dd060
  - [02/28] be2net: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/b4e24578b484
  - [03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/5f00358b5e90
  - [04/28] bnx2x: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/2fba753cc9b5
  - [05/28] bnxt: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/5f29b73d4eba
  - [06/28] cxgb4: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/ca7f175fc24e
  - [07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/49f79ac22f89
  - [08/28] net: hns3: remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/c183033f631a
  - [09/28] netxen_nic: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/2d0e0372069d
  - [10/28] octeon_ep: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/fe3f4c292da1
  - [11/28] qed: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1263c7b78315
  - [12/28] net: qede: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/5f1fbdc168f4
  - [13/28] qlcnic: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/95e35f599407
  - [14/28] qlcnic: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/e07ce5567194
  - [15/28] sfc: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/bdedf705688c
  - [16/28] sfc: falcon: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/4ac9272691a4
  - [17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/ecded61ceb89
  - [18/28] sfc_ef100: Drop redundant pci_disable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/c39abdd396bc
  - [19/28] net: ngbe: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/a7edf8e5142f
  - [20/28] net: txgbe: Drop redundant pci_enable_pcie_error_reporting()
    https://git.kernel.org/netdev/net-next/c/1fccc781bf7e
  - [21/28] e1000e: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/ab76f2bff0f3
  - [22/28] fm10k: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/8be901a6715f
  - [23/28] i40e: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/acd2bb015fae
  - [24/28] iavf: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/495b72c79302
  - [25/28] ice: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/ddd652ef30e3
  - [26/28] igb: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/648a2020fdac
  - [27/28] igc: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/1530522f101f
  - [28/28] ixgbe: Remove unnecessary aer.h include
    https://git.kernel.org/netdev/net-next/c/f3468e394439

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include
  2023-03-07 18:19 ` [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
@ 2023-03-15 12:00   ` naamax.meir
  0 siblings, 0 replies; 5+ messages in thread
From: naamax.meir @ 2023-03-15 12:00 UTC (permalink / raw)
  To: Bjorn Helgaas, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: netdev, linux-kernel, Jesse Brandeburg, Tony Nguyen,
	Bjorn Helgaas, intel-wired-lan

On 3/7/2023 20:19, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> <linux/aer.h> is unused, so remove it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 1 -
>   1 file changed, 1 deletion(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-15 12:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-07 18:19 [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
2023-03-07 18:19 ` [Intel-wired-lan] [PATCH 21/28] e1000e: Remove unnecessary aer.h include Bjorn Helgaas
2023-03-15 12:00   ` naamax.meir
2023-03-07 19:28 ` [Intel-wired-lan] [PATCH 00/28] PCI/AER: Remove redundant Device Control Error Reporting Enable Jesse Brandeburg
2023-03-09  7:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox