From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level
Date: Tue, 3 Nov 2015 23:05:12 +0000 [thread overview]
Message-ID: <1446591912.3990.28.camel@intel.com> (raw)
In-Reply-To: <804857E1F29AAC47BF68C404FC60A1847EC762DE@ORSMSX105.amr.corp.intel.com>
On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote:
> > -----Original Message-----
> > From: Keller, Jacob E
> > Sent: Tuesday, November 03, 2015 11:35 AM
> > To: Intel Wired LAN
> > Cc: Allan, Bruce W; Keller, Jacob E
> > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue at
> > global level
> >
> > From: Bruce Allan <bruce.w.allan@intel.com>
> >
> > Cleans up checkpatch GLOBAL_INITIALIZERS error
> >
> > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > ---
> > -v2
> > * Fix title from checkpatch complaint
>
> Out of curiosity, what was wrong with the original v1 patch title and
> what was the exact checkpatch complaint?
>
checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch
GLOBAL_INITIALISERS error"
WARNING:EMAIL_SUBJECT: A patch subject line should describe the change
not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Regards,
Jake
next prev parent reply other threads:[~2015-11-03 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 19:35 [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level Jacob Keller
2015-11-03 22:40 ` Allan, Bruce W
2015-11-03 23:05 ` Keller, Jacob E [this message]
2015-11-03 23:15 ` Allan, Bruce W
2015-11-03 23:19 ` Keller, Jacob E
2015-11-03 23:22 ` Allan, Bruce W
2015-11-03 23:31 ` Keller, Jacob E
2015-11-09 23:06 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446591912.3990.28.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox