[Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level

[Keller, Jacob E <jacob.e.keller@intel.com>]

On Tue, 2015-11-03 at 23:22 +0000, Allan, Bruce W wrote:
> > -----Original Message-----
> > From: Keller, Jacob E
> > Sent: Tuesday, November 03, 2015 3:20 PM
> > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
> > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue at
> > global
> > level
> > 
> > On Tue, 2015-11-03 at 23:15 +0000, Allan, Bruce W wrote:
> > > > -----Original Message-----
> > > > From: Keller, Jacob E
> > > > Sent: Tuesday, November 03, 2015 3:05 PM
> > > > To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
> > > > Subject: Re: [PATCH v2] fm10k: don't initialize fm10k_workqueue
> > > > at
> > > > global
> > > > level
> > > > 
> > > > On Tue, 2015-11-03 at 22:40 +0000, Allan, Bruce W wrote:
> > > > > > -----Original Message-----
> > > > > > From: Keller, Jacob E
> > > > > > Sent: Tuesday, November 03, 2015 11:35 AM
> > > > > > To: Intel Wired LAN
> > > > > > Cc: Allan, Bruce W; Keller, Jacob E
> > > > > > Subject: [PATCH v2] fm10k: don't initialize fm10k_workqueue
> > > > > > at
> > > > > > global level
> > > > > > 
> > > > > > From: Bruce Allan <bruce.w.allan@intel.com>
> > > > > > 
> > > > > > Cleans up checkpatch GLOBAL_INITIALIZERS error
> > > > > > 
> > > > > > Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> > > > > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > > > > > ---
> > > > > > -v2
> > > > > > * Fix title from checkpatch complaint
> > > > > 
> > > > > Out of curiosity, what was wrong with the original v1 patch
> > > > > title
> > > > > and
> > > > > what was the exact checkpatch complaint?
> > > > > 
> > > > 
> > > > checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch
> > > > GLOBAL_INITIALISERS error"
> > > > 
> > > > WARNING:EMAIL_SUBJECT: A patch subject line should describe the
> > > > change
> > > > not the tool that found it
> > > > #4:
> > > > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS
> > > > error
> > > > 
> > > > total: 0 errors, 1 warnings, 0 checks, 24 lines checked
> > > > 
> > > > 
> > > > Regards,
> > > > Jake
> > > 
> > > Which version of checkpatch and options did you use?  I tried
> > > with
> > > the one in Jeff's tree and others but do not get the same.
> > 
> > 
> > The one in Jeff's tree did it for me, and has been since commit
> > 
> > a2fe16b9d878 ("checkpatch: try to avoid poor patch subject lines")
> > 
> > I get:
> > 
> > 
> > WARNING: A patch subject line should describe the change not the
> > tool that
> > found it
> > #4:
> > Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error
> > 
> > total: 0 errors, 1 warnings, 0 checks, 24 lines checked
> > 
> > Your patch has style problems, please review.
> > 
> > NOTE: If any of the errors are false positives, please report
> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > 
> > 
> > Regards,
> > Jake
> 
> Very odd, since it seems we are doing the same thing but get
> different results :(


Do:

$git ls-tree HEAD scripts/checkpatch.pl

What is the output you get?

I get:
100755 blob f2a1131b2f8baf06f28e286d6b9203d4d1a873f6    scripts/checkpatch.pl

If you get the same sha1, then we should ensure we're checking the same
commit output.

I ran the following commit from my reflog into checkpatch:
4917fe7bef67 ("fm10k: fix checkpatch GLOBAL_INITIALISERS error")


which I have also attached to this email in format patch format.

Is it possible you're only showing the contents of the diff and not the
actual subject header? This checkpatch warning won't show up if you
don't pass it a full commit data and only pass it a diff.

Regards,
Jake
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fm10k-fix-checkpatch-GLOBAL_INITIALISERS-error.patch
Type: text/x-patch
Size: 1492 bytes
Desc: 0001-fm10k-fix-checkpatch-GLOBAL_INITIALISERS-error.patch
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151103/e19c9f75/attachment.bin>